-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SpecificityAtSensitivity Metric #1432
Merged
justusschock
merged 47 commits into
Lightning-AI:master
from
shenoynikhil:specificity-at-sensitivity
Jan 27, 2023
Merged
Add SpecificityAtSensitivity Metric #1432
justusschock
merged 47 commits into
Lightning-AI:master
from
shenoynikhil:specificity-at-sensitivity
Jan 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
shenoynikhil
changed the title
Added SpecificityAtSensitivity Metrics
Add SpecificityAtSensitivity Metrics
Jan 7, 2023
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…metrics into specificity-at-sensitivity
shenoynikhil
requested review from
Borda,
SkafteNicki,
justusschock,
tchaton and
ethanwharris
as code owners
January 7, 2023 07:13
@Borda @stancld @SkafteNicki If you can provide some feedback on the edge cases (all positive and all negative), that would be great. I just wrote the edge case based on the |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1432 +/- ##
========================================
- Coverage 90% 51% -38%
========================================
Files 211 213 +2
Lines 10839 10986 +147
========================================
- Hits 9717 5657 -4060
- Misses 1122 5329 +4207 |
for more information, see https://pre-commit.ci
…metrics into specificity-at-sensitivity
shenoynikhil
changed the title
Add SpecificityAtSensitivity Metrics
Add SpecificityAtSensitivity Metric
Jan 23, 2023
src/torchmetrics/functional/classification/specificity_at_sensitivity.py
Outdated
Show resolved
Hide resolved
…metrics into specificity-at-sensitivity
Borda
approved these changes
Jan 27, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Partially Fixes #971. Introduces the
SpecificityAtSensitivity
Metric. The computation is as follows,1 - false positive rate
is specificityPseudoCode
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃