Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fault-tolerant: fix resetting "current" progress at the end of successful epoch #8837

Closed
wants to merge 1 commit into from
+4 −0
Closed

fault-tolerant: fix resetting "current" progress at the end of successful epoch #8837

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions pytorch_lightning/loops/epoch/training_epoch_loop.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,6 +229,10 @@ def on_run_end(self) -> List[List[STEP_OUTPUT]]:

self.update_lr_schedulers("epoch", update_plateau_schedulers=True)

self.batch_progress.current.reset()
self.scheduler_progress.current.reset()
self.batch_loop.optim_progress.reset_on_epoch()
Comment on lines +232 to +234
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as in reset() above line 90-93

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably worth extracting into a protected method

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to move batch_loop.optim_progress reset to its own loop ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notice that it's calling reset_on_epoch, not reset. This loop is the epoch loop


epoch_output = self._epoch_output
# free memory
self._epoch_output = None
Expand Down