fault-tolerant: fix resetting "current" progress at the end of successful epoch #8837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awaelchli
commented
Aug 10, 2021
Comment on lines
+232
to
+234
| self.batch_progress.current.reset() | ||
| self.scheduler_progress.current.reset() | ||
| self.batch_loop.optim_progress.reset_on_epoch() |
There was a problem hiding this comment.
same as in reset() above line 90-93
There was a problem hiding this comment.
Probably worth extracting into a protected method
Codecov Report
@@ Coverage Diff @@
## master #8837 +/- ##
========================================
- Coverage 89% 43% -45%
========================================
Files 169 169
Lines 14072 14072
========================================
- Hits 12466 6117 -6349
- Misses 1606 7955 +6349 |
tchaton
reviewed
Aug 11, 2021
| @@ -229,6 +229,10 @@ def on_run_end(self) -> List[List[STEP_OUTPUT]]: | |||
|
|
|||
| self.update_lr_schedulers("epoch", update_plateau_schedulers=True) | |||
|
|
|||
| self.batch_progress.current.reset() | |||
| self.scheduler_progress.current.reset() | |||
| self.batch_loop.optim_progress.reset_on_epoch() | |||
There was a problem hiding this comment.
Is it possible to move batch_loop.optim_progress reset to its own loop ?
There was a problem hiding this comment.
Notice that it's calling reset_on_epoch, not reset. This loop is the epoch loop
carmocca
reviewed
Aug 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #8835
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃