Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update package info #768

Merged
merged 4 commits into from
Feb 1, 2020
Merged

update package info #768

merged 4 commits into from
Feb 1, 2020

Conversation

Borda
Copy link
Member

@Borda Borda commented Jan 29, 2020

What does this PR do?

Update some package information like year or version is devel now...
Partially fixing #731 and duplicate to #761
Adding budge for Appveyor #626
Also fixed:

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

@@ -106,6 +105,7 @@ def forward(self, batch):
return logits

"""
warnings.warn('Model does not have implemented `forward` method.')
Copy link
Member Author

@Borda Borda Jan 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather keep this abstract so a user has to willingly replace/fill by pass... @williamFalcon @neggert

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Borda that breaks convention with pytorch. let's not keep this abstract.

@Borda Borda added feature Is an improvement or enhancement need fix labels Jan 31, 2020
@Borda Borda added this to the 0.6.1 milestone Jan 31, 2020
@Borda Borda requested a review from jeffling January 31, 2020 21:24
@williamFalcon williamFalcon merged commit 5e97e66 into Lightning-AI:master Feb 1, 2020
@Borda Borda deleted the devel branch February 1, 2020 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Is an improvement or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants