Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update __init__.py #761

Closed
wants to merge 2 commits into from
Closed

Conversation

juliengrenier
Copy link

This prevent the python logging module to override the pytorch_lightning.logging module. This fix issue #731

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos, doc improvements)
  • Did you read the contributor guideline?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes # (issue).

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

This prevent the python `logging` module to override the `pytorch_lightning.logging` module. This fix issue Lightning-AI#731
@@ -28,11 +28,12 @@
from .trainer.trainer import Trainer
from .core.lightning import LightningModule
from .core.decorators import data_loader
import logging

def set_logger_level():
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather use from logging import basicConfig

@Borda Borda mentioned this pull request Jan 29, 2020
@williamFalcon
Copy link
Contributor

@Borda is this still alive? should we close?

@Borda Borda closed this Feb 2, 2020
@juliengrenier juliengrenier deleted the patch-2 branch February 14, 2020 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants