Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix: drop pyyaml 5.4.* [feat-1.2] #5609

Merged
merged 1 commit into from
Jan 22, 2021
Merged

hotfix: drop pyyaml 5.4.* [feat-1.2] #5609

merged 1 commit into from
Jan 22, 2021

Conversation

Borda
Copy link
Member

@Borda Borda commented Jan 21, 2021

What does this PR do?

identical fix as #5606 just to feature 1.2 branch

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified
  • Check that target branch and milestone match!

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added bug Something isn't working priority: 0 High priority task 3rd party Related to a 3rd-party labels Jan 21, 2021
@Borda Borda added this to the 1.2 milestone Jan 21, 2021
@Borda Borda enabled auto-merge (squash) January 21, 2021 21:24
@Borda Borda self-assigned this Jan 21, 2021
@Borda Borda added the ready PRs ready to be merged label Jan 21, 2021
@mergify mergify bot requested a review from a team January 21, 2021 21:50
@codecov
Copy link

codecov bot commented Jan 21, 2021

Codecov Report

Merging #5609 (ba78790) into release/1.2-dev (24462dc) will decrease coverage by 0%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##           release/1.2-dev   #5609   +/-   ##
===============================================
- Coverage               93%     92%   -0%     
===============================================
  Files                  153     153           
  Lines                10815   10815           
===============================================
- Hits                 10006   10000    -6     
- Misses                 809     815    +6     

@mergify mergify bot requested a review from a team January 21, 2021 22:48
@Borda Borda merged commit 671887f into release/1.2-dev Jan 22, 2021
@Borda Borda deleted the reg/yaml branch January 22, 2021 02:43
@Borda Borda mentioned this pull request Jan 22, 2021
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3rd party Related to a 3rd-party bug Something isn't working priority: 0 High priority task ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants