-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hotfix: drop bad pyyaml version #5606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Borda
requested review from
awaelchli,
justusschock,
SeanNaren,
tchaton and
williamFalcon
as code owners
January 21, 2021 20:02
tchaton
approved these changes
Jan 21, 2021
Borda
requested review from
ananyahjha93,
carmocca,
s-rog,
SkafteNicki,
yukw777 and
zippeurfou
January 21, 2021 20:10
carmocca
approved these changes
Jan 21, 2021
carmocca
reviewed
Jan 21, 2021
SeanNaren
approved these changes
Jan 21, 2021
Borda
changed the title
hotfix: drop bad pyyaml version
hotfix: drop bad pyyaml version [wip]
Jan 21, 2021
Borda
changed the title
hotfix: drop bad pyyaml version [wip]
hotfix: drop bad pyyaml version
Jan 21, 2021
Codecov Report
@@ Coverage Diff @@
## master #5606 +/- ##
======================================
Coverage 93% 93%
======================================
Files 135 135
Lines 10005 10005
======================================
Hits 9339 9339
Misses 666 666 |
12 tasks
tchaton
pushed a commit
that referenced
this pull request
Feb 3, 2021
* drop potetionaly bad version * *
Borda
added a commit
that referenced
this pull request
Feb 4, 2021
* drop potetionaly bad version * *
tchaton
pushed a commit
that referenced
this pull request
Feb 4, 2021
* drop potetionaly bad version * *
Borda
added a commit
that referenced
this pull request
Feb 4, 2021
* drop potetionaly bad version * *
Borda
added a commit
that referenced
this pull request
Feb 4, 2021
* drop potetionaly bad version * *
Borda
added a commit
that referenced
this pull request
Feb 4, 2021
* drop potetionaly bad version * *
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
just a hotfix for the recent pyyaml release which seems to work badly with Namespace
see: yaml/pyyaml#482
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃