-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use xm.save to save model on TPU #3044
Conversation
617276e
to
c06557b
Compare
Hello @lezwon! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-09-19 09:57:09 UTC |
Hey @lezwon, any ETA on this fix? |
@edenafek it has a lot of breaking changes. Also there was an issue due to which it was hanging at the 4th epoch. |
removed assert global_rank from on_validation_end
This reverts commit 6e02c95
8ac6eeb
to
c883572
Compare
@lezwon how is this going, can we get it done today? |
@lezwon can we revive this fix? |
@edenlightning I'm using a new branch to fix this issue. Will close this one as it is stale. |
@lezwon mind link here the new PR? |
What does this PR do?
Fixes #2700
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃