skip best_model_path if checkpoint_callback is None #2962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @lezwon! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-10-01 00:51:34 UTC |
|
This pull request is now in conflict... :( |
lezwon
force-pushed
the
no_checkpoint_tpu_fix
branch
from
662d168 to
056bf5e
Compare
|
@lezwon how is it going? seems quite ready to go... 🐰 |
lezwon
force-pushed
the
no_checkpoint_tpu_fix
branch
from
6b27dc2 to
7173a4c
Compare
Borda
changed the title
awaelchli
reviewed
Sep 30, 2020
Comment on lines
+70
to
+71
| if self.trainer.checkpoint_callback is not None: | ||
| self.trainer.checkpoint_callback.best_model_path = best_path |
There was a problem hiding this comment.
how about we just merge this one line fix into master? This would close the issue before release and you can still figure out the hard testing part for TPU in the other PR that's blocking this.
cc @Borda
There was a problem hiding this comment.
That's sounds good 👍
lezwon
force-pushed
the
no_checkpoint_tpu_fix
branch
from
7173a4c to
51f495b
Compare
lezwon
changed the title
Codecov Report
@@ Coverage Diff @@
## master #2962 +/- ##
=======================================
+ Coverage 85% 90% +5%
=======================================
Files 108 108
Lines 8433 8387 -46
=======================================
+ Hits 7191 7584 +393
+ Misses 1242 803 -439 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes training error when
checkpoint_callback=Falseis set during training on TPU.Fixes #2961
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃