Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add testing for PyTorch 2.4 (Fabric) #20028

Merged
merged 19 commits into from
Jul 2, 2024
+84 −104
Merged

Add testing for PyTorch 2.4 (Fabric) #20028

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
4ff0ea8
Add testing for PyTorch 2.4 (Fabric)
awaelchli Jun 30, 2024
9e62bf6
typing
awaelchli Jun 30, 2024
09d4aaf
debug
awaelchli Jun 30, 2024
a2da137
skip
awaelchli Jun 30, 2024
d55a478
typing
awaelchli Jun 30, 2024
ebdc431
deprecated state_dict
awaelchli Jun 30, 2024
6ea0872
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jun 30, 2024
c018e4c
update
awaelchli Jun 30, 2024
001aa26
Merge branch 'tests/pytorch-2.4-fabric' of github.com:Lightning-AI/li…
awaelchli Jun 30, 2024
c147d10
docs
awaelchli Jun 30, 2024
fe8d143
filterwarnings
awaelchli Jun 30, 2024
9909adb
futurewarnings
awaelchli Jun 30, 2024
9243486
reset docker build
awaelchli Jun 30, 2024
2f8402f
delete obsolete test
awaelchli Jun 30, 2024
116fec6
store python version in env variable
awaelchli Jun 30, 2024
a83b75b
exclude windows
awaelchli Jun 30, 2024
2c75547
Merge branch 'master' into tests/pytorch-2.4-fabric
awaelchli Jun 30, 2024
8a5069e
Merge branch 'master' into tests/pytorch-2.4-fabric
awaelchli Jun 30, 2024
300fc6f
fix bad merge resolution
awaelchli Jun 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Loading
Loading status checks…
deprecated state_dict
@awaelchli
awaelchli committed Jun 30, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
commit ebdc43160552203f12327797e14babc73dd9dadf
2 changes: 1 addition & 1 deletion tests/tests_fabric/strategies/test_fsdp_integration.py
View file
Original file line number Diff line number Diff line change
@@ -174,7 +174,7 @@ def test_train_save_load(tmp_path, manual_wrapping, precision):
assert state["coconut"] == 11


@RunIf(min_cuda_gpus=2, standalone=True)
@RunIf(min_cuda_gpus=2, standalone=True, max_torch="2.4")
def test_save_full_state_dict(tmp_path):
"""Test that FSDP saves the full state into a single file with `state_dict_type="full"`."""
fabric = Fabric(