-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: switch imports for pytorch #16595
Conversation
spill pending on #16592 |
⚡ Required checks status: All passing 🟢Groups summary🟢 pytorch_lightning: Tests workflowThese checks are required after the changes to 🟢 pytorch_lightning: Azure GPU
These checks are required after the changes to 🟢 pytorch_lightning: Benchmarks
These checks are required after the changes to 🟢 pytorch_lightning: Azure HPU
These checks are required after the changes to 🟢 pytorch_lightning: Azure IPU
These checks are required after the changes to 🟢 lightning_fabric: CPU workflow
These checks are required after the changes to 🟢 lightning_fabric: Azure GPU
These checks are required after the changes to Thank you for your contribution! 💜
|
for more information, see https://pre-commit.ci
a7b0be6
to
528b3f7
Compare
seems we have a bug in utils package as this code for installing only PL return both true: from lightning_utilities.core.imports import package_available
print(module_available("lightning"))
print(module_available("pytorch_lightning")) |
What does this PR do?
as in #16594 we are moving to lightning, so switching also primary imports in tests and updating CI accordingly... note that this shall have green checks on its own so it can be merged even before referred PR rabbit
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃
cc @Borda @carmocca @akihironitta