Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

false positive with package_available #95

Closed
Borda opened this issue Feb 2, 2023 · 1 comment
Closed

false positive with package_available #95

Borda opened this issue Feb 2, 2023 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed won't fix

Comments

@Borda
Copy link
Member

Borda commented Feb 2, 2023

🐛 Bug

Seems we have a bug in the utils package, as this code for installing only PL from source return both true...

To Reproduce

Lightning-AI/pytorch-lightning#16595 (comment)

Code sample

from lightning_utilities.core.imports import package_available
print(module_available("lightning"))
print(module_available("pytorch_lightning"))

Expected behavior

Environment

  • lightning-utilities==0.6.0.post0

Additional context
@Borda Borda added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers labels Feb 2, 2023
@stale
Copy link

stale bot commented Apr 13, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the won't fix label Apr 13, 2023
@Borda Borda closed this as completed May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed won't fix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Borda