Add CSVLogger for Lightning Lite #16346

awaelchli · 2023-01-12T14:58:22Z

What does this PR do?

Follow up to #16121 which introduced the logger base class and the TensorBoardLogger as a first implementation.
Now we are adding the lightweight CSVLogger too.

Before submitting

Was this discussed/approved via a GitHub issue? (not for typos and docs)
Did you read the contributor guideline, Pull Request section?
Did you make sure your PR does only one thing, instead of bundling different changes together?
Did you make sure to update the documentation with your changes? (if necessary)
Did you write any new necessary tests? (not for typos and docs)
Did you verify new and existing tests pass locally with your changes?
Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

Is this pull request ready for review? (if not, please submit in draft mode)
Check that all items from Before submitting are resolved
Make sure the title is self-explanatory and the description concisely explains the PR
Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

cc @carmocca @justusschock @awaelchli @Borda

for more information, see https://pre-commit.ci

docs docs

github-actions · 2023-01-12T21:39:40Z

⚡ Required checks status: All passing 🟢

Groups summary

🟢 pytorch_lightning: Tests workflow

Check ID	Status
pl-cpu (macOS-11, pytorch, 3.8, 1.11)	success	✅
pl-cpu (macOS-11, pytorch, 3.9, 1.12)	success	✅
pl-cpu (macOS-11, pytorch, 3.10, 1.13)	success	✅
pl-cpu (macOS-11, pytorch, 3.8, 1.10, oldest)	success	✅
pl-cpu (ubuntu-20.04, pytorch, 3.8, 1.10)	success	✅
pl-cpu (ubuntu-20.04, pytorch, 3.9, 1.11)	success	✅
pl-cpu (ubuntu-20.04, pytorch, 3.10, 1.12)	success	✅
pl-cpu (ubuntu-20.04, pytorch, 3.10, 1.13)	success	✅
pl-cpu (ubuntu-20.04, pytorch, 3.7, 1.10, oldest)	success	✅
pl-cpu (windows-2022, pytorch, 3.9, 1.11)	success	✅
pl-cpu (windows-2022, pytorch, 3.10, 1.12)	success	✅
pl-cpu (windows-2022, pytorch, 3.10, 1.13)	success	✅
pl-cpu (windows-2022, pytorch, 3.7, 1.10, oldest)	success	✅
pl-cpu (slow, macOS-11, pytorch, 3.7, 1.11)	success	✅
pl-cpu (slow, ubuntu-20.04, pytorch, 3.7, 1.11)	success	✅
pl-cpu (slow, windows-2022, pytorch, 3.7, 1.11)	success	✅
pl-cpu (macOS-11, lightning, 3.8, 1.13)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.8, 1.13)	success	✅
pl-cpu (windows-2022, lightning, 3.8, 1.13)	success	✅

These checks are required after the changes to src/lightning_fabric/loggers/__init__.py, src/lightning_fabric/loggers/csv_logs.py, src/lightning_fabric/loggers/tensorboard.py, src/pytorch_lightning/loggers/csv_logs.py.

🟢 pytorch_lightning: Azure GPU

Check ID	Status
pytorch-lightning (GPUs)	success	✅

These checks are required after the changes to src/pytorch_lightning/loggers/csv_logs.py, src/lightning_fabric/loggers/__init__.py, src/lightning_fabric/loggers/csv_logs.py, src/lightning_fabric/loggers/tensorboard.py.

🟢 pytorch_lightning: Azure HPU

Check ID	Status
pytorch-lightning (HPUs)	success	✅

These checks are required after the changes to src/lightning_fabric/loggers/__init__.py, src/lightning_fabric/loggers/csv_logs.py, src/lightning_fabric/loggers/tensorboard.py, src/pytorch_lightning/loggers/csv_logs.py.

🟢 pytorch_lightning: Azure IPU

Check ID	Status
pytorch-lightning (IPUs)	success	✅

These checks are required after the changes to src/lightning_fabric/loggers/__init__.py, src/lightning_fabric/loggers/csv_logs.py, src/lightning_fabric/loggers/tensorboard.py, src/pytorch_lightning/loggers/csv_logs.py.

🟢 pytorch_lightning: Docs

Check ID	Status
make-doctest (pytorch)	success	✅
make-html (pytorch)	success	✅

These checks are required after the changes to src/pytorch_lightning/loggers/csv_logs.py, docs/source-pytorch/fabric/api/api_reference.rst, docs/source-pytorch/fabric/fabric.rst, docs/source-pytorch/fabric/guide/logging.rst.

🟢 lightning_fabric: CPU workflow

Check ID	Status
fabric-cpu (macOS-11, fabric, 3.8, 1.11)	success	✅
fabric-cpu (macOS-11, fabric, 3.9, 1.12)	success	✅
fabric-cpu (macOS-11, fabric, 3.10, 1.13)	success	✅
fabric-cpu (macOS-11, fabric, 3.7, 1.10, oldest)	success	✅
fabric-cpu (ubuntu-20.04, fabric, 3.8, 1.10)	success	✅
fabric-cpu (ubuntu-20.04, fabric, 3.9, 1.11)	success	✅
fabric-cpu (ubuntu-20.04, fabric, 3.10, 1.12)	success	✅
fabric-cpu (ubuntu-20.04, fabric, 3.10, 1.13)	success	✅
fabric-cpu (ubuntu-20.04, fabric, 3.7, 1.10, oldest)	success	✅
fabric-cpu (windows-2022, fabric, 3.9, 1.11)	success	✅
fabric-cpu (windows-2022, fabric, 3.10, 1.12)	success	✅
fabric-cpu (windows-2022, fabric, 3.10, 1.13)	success	✅
fabric-cpu (windows-2022, fabric, 3.7, 1.10, oldest)	success	✅
fabric-cpu (macOS-11, lightning, 3.8, 1.13)	success	✅
fabric-cpu (ubuntu-20.04, lightning, 3.8, 1.13)	success	✅
fabric-cpu (windows-2022, lightning, 3.8, 1.13)	success	✅

These checks are required after the changes to src/lightning_fabric/loggers/__init__.py, src/lightning_fabric/loggers/csv_logs.py, src/lightning_fabric/loggers/tensorboard.py, tests/tests_fabric/loggers/test_csv.py.

🟢 lightning_fabric: Azure GPU

Check ID	Status
lightning-fabric (GPUs)	success	✅

These checks are required after the changes to src/lightning_fabric/loggers/__init__.py, src/lightning_fabric/loggers/csv_logs.py, src/lightning_fabric/loggers/tensorboard.py, tests/tests_fabric/loggers/test_csv.py.

🟢 mypy

Check ID	Status
mypy	success	✅

These checks are required after the changes to src/lightning_fabric/loggers/__init__.py, src/lightning_fabric/loggers/csv_logs.py, src/lightning_fabric/loggers/tensorboard.py, src/pytorch_lightning/loggers/csv_logs.py.

🟢 install

Check ID	Status
install-pkg (ubuntu-22.04, app, 3.7)	success	✅
install-pkg (ubuntu-22.04, app, 3.10)	success	✅
install-pkg (ubuntu-22.04, fabric, 3.7)	success	✅
install-pkg (ubuntu-22.04, fabric, 3.10)	success	✅
install-pkg (ubuntu-22.04, pytorch, 3.7)	success	✅
install-pkg (ubuntu-22.04, pytorch, 3.10)	success	✅
install-pkg (ubuntu-22.04, lightning, 3.7)	success	✅
install-pkg (ubuntu-22.04, lightning, 3.10)	success	✅
install-pkg (ubuntu-22.04, notset, 3.7)	success	✅
install-pkg (ubuntu-22.04, notset, 3.10)	success	✅
install-pkg (macOS-12, app, 3.7)	success	✅
install-pkg (macOS-12, app, 3.10)	success	✅
install-pkg (macOS-12, fabric, 3.7)	success	✅
install-pkg (macOS-12, fabric, 3.10)	success	✅
install-pkg (macOS-12, pytorch, 3.7)	success	✅
install-pkg (macOS-12, pytorch, 3.10)	success	✅
install-pkg (macOS-12, lightning, 3.7)	success	✅
install-pkg (macOS-12, lightning, 3.10)	success	✅
install-pkg (macOS-12, notset, 3.7)	success	✅
install-pkg (macOS-12, notset, 3.10)	success	✅
install-pkg (windows-2022, app, 3.7)	success	✅
install-pkg (windows-2022, app, 3.10)	success	✅
install-pkg (windows-2022, fabric, 3.7)	success	✅
install-pkg (windows-2022, fabric, 3.10)	success	✅
install-pkg (windows-2022, pytorch, 3.7)	success	✅
install-pkg (windows-2022, pytorch, 3.10)	success	✅
install-pkg (windows-2022, lightning, 3.7)	success	✅
install-pkg (windows-2022, lightning, 3.10)	success	✅
install-pkg (windows-2022, notset, 3.7)	success	✅
install-pkg (windows-2022, notset, 3.10)	success	✅

These checks are required after the changes to src/lightning_fabric/loggers/__init__.py, src/lightning_fabric/loggers/csv_logs.py, src/lightning_fabric/loggers/tensorboard.py, src/pytorch_lightning/loggers/csv_logs.py.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

src/lightning_fabric/CHANGELOG.md

csv logger

d8b376a

awaelchli added fabric lightning.fabric.Fabric logger: csv labels Jan 12, 2023

github-actions bot added the pl Generic label for PyTorch Lightning package label Jan 12, 2023

pre-commit-ci bot and others added 9 commits January 12, 2023 15:00

[pre-commit.ci] auto fixes from pre-commit.com hooks

0272bc3

for more information, see https://pre-commit.ci

fixes

0a31141

Merge branch 'master' into lite/csv-logger

9ef2ced

share code through inheritance meh..

2a56f1a

[pre-commit.ci] auto fixes from pre-commit.com hooks

86f92b4

for more information, see https://pre-commit.ci

Merge branch 'master' into lite/csv-logger

2600392

include loggers in docs

3b17f4a

docs for multiple loggers

888eb04

changelog

796be27

awaelchli added this to the v1.9 milestone Jan 12, 2023

docs

edd4cf9

docs docs

awaelchli force-pushed the lite/csv-logger branch from 7fddf01 to edd4cf9 Compare January 12, 2023 21:39

awaelchli marked this pull request as ready for review January 12, 2023 21:39

awaelchli requested review from carmocca, justusschock, williamFalcon, edenlightning, tchaton and Borda as code owners January 12, 2023 21:39

mergify bot added the has conflicts label Jan 13, 2023

Merge branch 'master' into lite/csv-logger

0aed418

mergify bot removed the has conflicts label Jan 13, 2023

Borda approved these changes Jan 13, 2023

View reviewed changes

carmocca approved these changes Jan 13, 2023

View reviewed changes

src/lightning_fabric/CHANGELOG.md Show resolved Hide resolved

mergify bot added the ready PRs ready to be merged label Jan 13, 2023

another way of making chlog less confusing

f139b4e

awaelchli enabled auto-merge (squash) January 13, 2023 12:36

awaelchli merged commit 8f12692 into master Jan 13, 2023

awaelchli deleted the lite/csv-logger branch January 13, 2023 13:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add CSVLogger for Lightning Lite #16346

Add CSVLogger for Lightning Lite #16346

awaelchli commented Jan 12, 2023 •

edited by github-actions bot

Loading

github-actions bot commented Jan 12, 2023 •

edited

Loading

Add CSVLogger for Lightning Lite #16346

Add CSVLogger for Lightning Lite #16346

Conversation

awaelchli commented Jan 12, 2023 • edited by github-actions bot Loading

What does this PR do?

Before submitting

PR review

Did you have fun?

github-actions bot commented Jan 12, 2023 • edited Loading

⚡ Required checks status: All passing 🟢

Groups summary

awaelchli commented Jan 12, 2023 •

edited by github-actions bot

Loading

github-actions bot commented Jan 12, 2023 •

edited

Loading