-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logger support in Lite #16121
Merged
awaelchli
merged 21 commits into
Lightning-AI:master
from
lightningforever:lite/debug-logger
Jan 9, 2023
Merged
Logger support in Lite #16121
awaelchli
merged 21 commits into
Lightning-AI:master
from
lightningforever:lite/debug-logger
Jan 9, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
11 tasks
lightningforever
requested review from
awaelchli,
carmocca,
justusschock,
williamFalcon,
Borda and
tchaton
as code owners
December 20, 2022 17:33
justusschock
approved these changes
Dec 20, 2022
carmocca
reviewed
Dec 20, 2022
Borda
reviewed
Dec 20, 2022
tchaton
approved these changes
Dec 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT !
mergify
bot
added
has conflicts
ready
PRs ready to be merged
and removed
ready
PRs ready to be merged
has conflicts
labels
Dec 22, 2022
lightningforever
force-pushed
the
lite/debug-logger
branch
from
January 9, 2023 14:15
2e90ddf
to
8a743d3
Compare
mergify
bot
added
ready
PRs ready to be merged
and removed
has conflicts
ready
PRs ready to be merged
labels
Jan 9, 2023
auto-merge was automatically disabled
January 9, 2023 15:16
Head branch was pushed to by a user without write access
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds the logger base class and TensorBoardLogger implementation to Fabric.
The base class interface is mostly the same as in PyTorch Lightning, but with these key differences:
after_save_checkpoint
hook. Lite won't have the same checkpointing mechanism through callbacks, and thus we will have to rework the way loggers access checkpoints.DummyLogger
(only needed for Trainer)save_dir
->root_dir
. We are standardizing the way the log dir is defined, to be compatible with as many logger frameworks as possible. More info in IntroduceLogger.experiment_dir
#14188.The TensorBoard implementation changes very little. Trainer-only features and dependencies were removed:
save_dir
->root_dir
log_graph
argument in constructor (logging graph is still supported throughlogger.log_graph()
)Future Work:
self.log
in LightningModule will be added in WIP Add support forself.log
from LightningModule in Lite #16135Does your PR introduce any breaking changes? If yes, please list them.
No
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
I made sure I had fun coding 🙃