Skip to content

Conversation

@nmiculinic
Copy link
Contributor

@nmiculinic nmiculinic commented Oct 24, 2022

What does this PR do?

Since we currently only support us-east-1, until various things have been covered in https://lightningai.atlassian.net/browse/ENG-1402 and done more testing for different regions, we're hiding this CLI parameter, and only allowing us-east-1 region on the backend. This is temporary hiding until multi-region support is properly tested

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda

@nmiculinic nmiculinic self-assigned this Oct 24, 2022
@github-actions github-actions bot added the app (removed) Generic label for Lightning App package label Oct 24, 2022
@nmiculinic nmiculinic force-pushed the ENG-1404-cli-remove-region-flag-for-the-byoc-cluster-creation branch 2 times, most recently from 3d15ec9 to 7feaa1a Compare October 25, 2022 15:30
@nmiculinic nmiculinic marked this pull request as ready for review October 25, 2022 17:36
@nmiculinic nmiculinic force-pushed the ENG-1404-cli-remove-region-flag-for-the-byoc-cluster-creation branch from 7feaa1a to 2c4ee27 Compare October 25, 2022 17:36
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@mergify mergify bot added the ready PRs ready to be merged label Oct 26, 2022
@nmiculinic nmiculinic enabled auto-merge (squash) October 26, 2022 13:04
@nmiculinic nmiculinic added this to the v1.8 milestone Oct 26, 2022
@nmiculinic nmiculinic force-pushed the ENG-1404-cli-remove-region-flag-for-the-byoc-cluster-creation branch 3 times, most recently from 88c5707 to bfb78a9 Compare October 27, 2022 11:29
Co-authored-by: Luca Antiga <[email protected]>
@nmiculinic nmiculinic force-pushed the ENG-1404-cli-remove-region-flag-for-the-byoc-cluster-creation branch from 1fa6bc1 to b31edf6 Compare October 27, 2022 15:04
@nmiculinic nmiculinic merged commit 478ca8c into master Oct 28, 2022
@nmiculinic nmiculinic deleted the ENG-1404-cli-remove-region-flag-for-the-byoc-cluster-creation branch October 28, 2022 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app (removed) Generic label for Lightning App package ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants