Merge branch 'master' into ENG-1404-cli-remove-region-flag-for-the-byoc-cluster-creation

Author: awaelchli

.github/workflows/legacy-checkpoints.yml

@@ -105,7 +105,7 @@ jobs:
         aws s3 cp checkpoints.zip s3://pl-public-data/legacy/ --acl public-read
       if: inputs.push_to_s3
 
-  enable-ckpt-test:
+  adding-ckpt-test:
     runs-on: ubuntu-20.04
     if: inputs.create_pr
     needs: create-legacy-ckpts
@@ -120,7 +120,7 @@ jobs:
     - name: Create Pull Request
       uses: peter-evans/create-pull-request@v4
       with:
-        title: Enable testing with legacy checkpiont created with ${{ needs.create-legacy-ckpts.outputs.pl-version }}
+        title: Adding test for legacy checkpiont created with ${{ needs.create-legacy-ckpts.outputs.pl-version }}
         delete-branch: true
         labels: |
           tests

.github/workflows/release-pypi.yml

@@ -116,9 +116,12 @@ jobs:
         pkg-pattern: "*"
         pypi-token: ${{ secrets.PYPI_TOKEN_LAI }}
 
-  create-legacy-ckpt:
+  legacy-checkpoints:
     needs: publish-packages
     uses: ./.github/workflows/legacy-checkpoints.yml
     with:
       push_to_s3: true
       create_pr: true
+    secrets:
+      AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
+      AWS_SECRET_KEY_ID: ${{ secrets.AWS_SECRET_KEY_ID }}

docs/source-pytorch/model/train_model_basic.rst

@@ -116,11 +116,11 @@ Under the hood, the Lightning Trainer runs the following training loop on your b
 
 .. code:: python
 
-    autoencoder = LitAutoEncoder(encoder, decoder)
+    autoencoder = LitAutoEncoder(Encoder(), Decoder())
     optimizer = autoencoder.configure_optimizers()
 
     for batch_idx, batch in enumerate(train_loader):
-        loss = autoencoder(batch, batch_idx)
+        loss = autoencoder.training_step(batch, batch_idx)
 
         loss.backward()
         optimizer.step()