Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(hot fix) Resolve Boring App #14684

Merged
merged 20 commits into from
Sep 13, 2022
Merged

(hot fix) Resolve Boring App #14684

merged 20 commits into from
Sep 13, 2022

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented Sep 13, 2022 •
edited by Borda
Loading

What does this PR do?

This PR resolves a bug introduced by this PR: #14464

Fixes #<issue_number>

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@github-actions github-actions bot added the app (removed) Generic label for Lightning App package label Sep 13, 2022
@tchaton tchaton marked this pull request as ready for review September 13, 2022 12:30
@tchaton tchaton added the bug Something isn't working label Sep 13, 2022
@tchaton tchaton changed the title Resolve Boring App (hot fix) Resolve Boring App Sep 13, 2022
@tchaton tchaton self-assigned this Sep 13, 2022
@tchaton tchaton added this to the app:0.7 milestone Sep 13, 2022
awaelchli
awaelchli approved these changes Sep 13, 2022
View reviewed changes
src/lightning_app/testing/testing.py Outdated Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label Sep 13, 2022
dmitsf
dmitsf approved these changes Sep 13, 2022
View reviewed changes
Copy link
Member

@dmitsf dmitsf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lexierule lexierule merged commit 96cc288 into master Sep 13, 2022
@lexierule lexierule deleted the resolve_boring_app branch September 13, 2022 14:50
@krshrimali krshrimali mentioned this pull request Sep 16, 2022
Closed
12 tasks
krshrimali pushed a commit that referenced this pull request Sep 16, 2022
@tchaton @krshrimali
(hot fix) Resolve Boring App (#14684)
25f4018 
* resolve_boring_app

* update

* update

* update

* update

* update

* update

* update

* update

* update

* update

* update

* update

* update
lexierule pushed a commit that referenced this pull request Sep 19, 2022
@tchaton @lexierule
(hot fix) Resolve Boring App (#14684)
aee5c02 
* resolve_boring_app

* update

* update

* update

* update

* update

* update

* update

* update

* update

* update

* update

* update

* update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Borda Borda Borda left review comments

@hhsecond hhsecond hhsecond approved these changes

@alecmerdler alecmerdler alecmerdler approved these changes

@ethanwharris ethanwharris ethanwharris approved these changes

@awaelchli awaelchli awaelchli approved these changes

@dmitsf dmitsf dmitsf approved these changes

@manskx manskx Awaiting requested review from manskx

Assignees

@tchaton tchaton

Labels
app (removed) Generic label for Lightning App package bug Something isn't working ready PRs ready to be merged
Projects
No open projects
Frameworks Planning
Status: Done
Milestone
app:0.7
Development

Successfully merging this pull request may close these issues.
8 participants
@tchaton @dmitsf @awaelchli @Borda @ethanwharris @alecmerdler @hhsecond @lexierule