Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(app) Make Logging DEBUG mode lazy #14464

Merged
merged 43 commits into from
Sep 12, 2022
Merged

(app) Make Logging DEBUG mode lazy #14464

merged 43 commits into from
Sep 12, 2022

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented Aug 31, 2022

What does this PR do?

This PR improves framework debugging by implying how to enable logging debug mode.

Right now, there is 2 different ways to enable it.

LIGHTNING_DEBUG=1 lightning run app ...
import lightning as L

L.LightningApp(..., debug=True)

Fixes #<issue_number>

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @carmocca @akihironitta @Borda

@tchaton tchaton marked this pull request as draft August 31, 2022 07:32
@github-actions github-actions bot added the app (removed) Generic label for Lightning App package label Aug 31, 2022
@tchaton tchaton changed the title Improve Debugging Make Logging DEBUG mode lazy Aug 31, 2022
@tchaton tchaton marked this pull request as ready for review August 31, 2022 08:14
@tchaton tchaton changed the title Make Logging DEBUG mode lazy (app) Make Logging DEBUG mode lazy Aug 31, 2022
@tchaton tchaton added the ci Continuous Integration label Aug 31, 2022
@tchaton tchaton added this to the app:0.6.x milestone Aug 31, 2022
@mergify mergify bot added the ready PRs ready to be merged label Aug 31, 2022
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Sep 1, 2022
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the user has regular logging, i.e. logging.getLogger(__name__) with debugging level instead of this special logger introduced here, this will still work as expected, right?

@tchaton
Copy link
Contributor Author

tchaton commented Sep 7, 2022

If the user has regular logging, i.e. logging.getLogger(__name__) with debugging level instead of this special logger introduced here, this will still work as expected, right?

Yes.

@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Sep 12, 2022
src/lightning_app/utilities/install_components.py Outdated Show resolved Hide resolved
src/lightning_app/utilities/install_components.py Outdated Show resolved Hide resolved
@tchaton tchaton enabled auto-merge (squash) September 12, 2022 13:00
@tchaton tchaton merged commit 86fd5b2 into master Sep 12, 2022
@tchaton tchaton deleted the resolve_ci_failure branch September 12, 2022 14:47
@tchaton tchaton mentioned this pull request Sep 13, 2022
12 tasks
krshrimali pushed a commit that referenced this pull request Sep 16, 2022
@krshrimali krshrimali mentioned this pull request Sep 16, 2022
12 tasks
lexierule pushed a commit that referenced this pull request Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app (removed) Generic label for Lightning App package ci Continuous Integration ready PRs ready to be merged
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants