-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(app) Make Logging DEBUG mode lazy #14464
Conversation
Co-authored-by: Mansy <[email protected]>
Co-authored-by: Mansy <[email protected]>
…lightning into resolve_ci_failure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the user has regular logging, i.e. logging.getLogger(__name__)
with debugging level instead of this special logger introduced here, this will still work as expected, right?
Yes. |
What does this PR do?
This PR improves framework debugging by implying how to enable logging debug mode.
Right now, there is 2 different ways to enable it.
Fixes #<issue_number>
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃
cc @carmocca @akihironitta @Borda