Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixing build meta pkg flow #13926

Merged
merged 6 commits into from
Aug 1, 2022
Merged

fixing build meta pkg flow #13926

merged 6 commits into from
Aug 1, 2022

Conversation

Borda
Copy link
Member

@Borda Borda commented Jul 29, 2022 •
edited
Loading

What does this PR do?

Debugging why the meta pkg is built with the wrong version...
resolves #13888
Also fixes installing the package as a standalone! broken in #13906

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @tchaton @rohitgr7 @carmocca @akihironitta @Borda

@Borda Borda changed the title CI: debug pulled version CI: fixing build meta pkg flow Jul 29, 2022
@Borda Borda added priority: 0 High priority task ci Continuous Integration labels Jul 29, 2022
@Borda Borda marked this pull request as ready for review July 29, 2022 13:26
@Borda Borda added priority: 1 Medium priority task priority: 0 High priority task release and removed priority: 0 High priority task priority: 1 Medium priority task labels Jul 29, 2022
@Borda Borda added this to the all:next milestone Jul 29, 2022
@Borda Borda enabled auto-merge (squash) July 29, 2022 13:43
@Borda Borda disabled auto-merge July 29, 2022 13:43
@Borda Borda enabled auto-merge (squash) July 29, 2022 13:44
@mergify mergify bot added the ready PRs ready to be merged label Jul 29, 2022
This was referenced Jul 29, 2022
Merged
Merged
@Borda Borda changed the title CI: fixing build meta pkg flow fixing build meta pkg flow Jul 29, 2022
@Borda Borda disabled auto-merge August 1, 2022 07:29
@Borda Borda enabled auto-merge (squash) August 1, 2022 07:32
@Borda Borda merged commit c65bbe0 into master Aug 1, 2022
@Borda Borda deleted the ci/meta-pkg branch August 1, 2022 08:00
Borda added a commit that referenced this pull request Aug 1, 2022
@Borda
fixing build meta pkg flow (#13926)
11acbc6 
* debug pulled version
* pre flags
* only meta

(cherry picked from commit c65bbe0)
lexierule pushed a commit that referenced this pull request Aug 1, 2022
@Borda @lexierule
fixing build meta pkg flow (#13926)
8af2e9a 
* debug pulled version
* pre flags
* only meta

(cherry picked from commit c65bbe0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manskx manskx manskx approved these changes

@otaj otaj otaj approved these changes

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@carmocca carmocca Awaiting requested review from carmocca

@akihironitta akihironitta Awaiting requested review from akihironitta

@awaelchli awaelchli Awaiting requested review from awaelchli

@ethanwharris ethanwharris Awaiting requested review from ethanwharris ethanwharris is a code owner

@hhsecond hhsecond Awaiting requested review from hhsecond

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

Assignees
No one assigned
Labels
ci Continuous Integration priority: 0 High priority task ready PRs ready to be merged release
Projects
None yet
Milestone
all:next
Development

Successfully merging this pull request may close these issues.

CI jobs to "install meta package" are failing
5 participants
@Borda @otaj @manskx @carmocca @akihironitta