Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta pkg: set version as today #13906

Merged
merged 4 commits into from
Jul 29, 2022
Merged

meta pkg: set version as today #13906

merged 4 commits into from
Jul 29, 2022

Conversation

Borda
Copy link
Member

@Borda Borda commented Jul 28, 2022

What does this PR do?

This removes accidentally not updated package version for normal release and keeps track of package creation for installation from the source

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda @tchaton @rohitgr7

@Borda Borda added the priority: 1 Medium priority task label Jul 28, 2022
@Borda Borda added this to the pl:future milestone Jul 28, 2022
@Borda Borda requested a review from a team July 28, 2022 12:58
@github-actions github-actions bot added the app (removed) Generic label for Lightning App package label Jul 28, 2022
@mergify mergify bot added the ready PRs ready to be merged label Jul 28, 2022
@Borda Borda modified the milestones: pl:future, all:next Jul 28, 2022
@Borda Borda enabled auto-merge (squash) July 29, 2022 12:16
@Borda Borda merged commit c136ef5 into master Jul 29, 2022
@Borda Borda deleted the pkg/meta-today branch July 29, 2022 12:37
@Borda Borda mentioned this pull request Jul 29, 2022
12 tasks
Borda added a commit that referenced this pull request Jul 29, 2022
lexierule pushed a commit that referenced this pull request Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app (removed) Generic label for Lightning App package priority: 1 Medium priority task ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants