Skip to content

Conversation

@carmocca
Copy link
Contributor

@carmocca carmocca commented May 21, 2023

Same as Lightning-AI/lit-llama#255

I haven't kept chat.py and generate.py at the root as some users were confused by which script to use, for instance #78. We can undo this if requested by reviewers.

@carmocca carmocca marked this pull request as ready for review May 21, 2023 19:31
@lantiga
Copy link
Contributor

lantiga commented May 29, 2023

Looks good but I'd keep this for when we don't have a lot of open PRs

@carmocca
Copy link
Contributor Author

@lantiga Since this PR is just moving files and not replacing contents, resolving conflicts should be as straightforward as merging main. But I'm okay with waiting for a better time

@carmocca
Copy link
Contributor Author

carmocca commented Jun 2, 2023

Merging now since there's just one other PR

@carmocca carmocca merged commit a905731 into main Jun 2, 2023
@carmocca carmocca deleted the carmocca/repo-directories branch June 2, 2023 17:36
@carmocca carmocca self-assigned this Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants