Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use internal build cli #179

Merged
merged 2 commits into from
Mar 3, 2019
Merged

Use internal build cli #179

merged 2 commits into from
Mar 3, 2019

Conversation

jdneo
Copy link
Member

@jdneo jdneo commented Mar 3, 2019

Try to resolve #74, #83, #103, #105

@poppinlp Please help review when you have time. Thanks!

@jdneo jdneo added this to the 0.12.0 milestone Mar 3, 2019
@jdneo jdneo requested a review from poppinlp March 3, 2019 07:56
@jdneo jdneo merged commit bc61447 into master Mar 3, 2019
@jdneo jdneo deleted the cs/cli branch March 3, 2019 11:09
@jdneo
Copy link
Member Author

jdneo commented Mar 3, 2019

Let me explain more about this PR.

In this PR, I change the dependency from leetcode-cli to vsc-leetcode-cli, which is a forked privacy build of the leetcode-cli. This is due to that the latest version of leetcode-cli has some broken features and inactive for a long time. So I have to replace it with my forked version.

So far I have no plan to write a new cli tool to replace it. I'm very willing to merge back to the origin leetcode-cli when it becomes active again.

@twchn
Copy link

twchn commented Mar 3, 2019

Using a forked version of leetcode-cli is a better choice I think, we can keep in sync with the upstream(leetcode-cli), and then fix known issues ASAP or customize the extra features we need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Power operator displays in a wrong way
2 participants