Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHP support #103

Closed
sohaha opened this issue Feb 4, 2019 · 7 comments
Closed

Add PHP support #103

sohaha opened this issue Feb 4, 2019 · 7 comments

Comments

@sohaha
Copy link

sohaha commented Feb 4, 2019

目前 leetcode 是支持 php 的了,能否考虑加上?
(不加其实也没事,估计也没 写 php 的会用吧🙅‍♂️,逃)

@jdneo jdneo changed the title 追加支持语言 Add PHP support Feb 4, 2019
@poppinlp
Copy link
Contributor

@sohaha Hi
This feature depends on the leetcode-cli package.
I've sent a PR for PHP supporting and we'll support it after they merge and release. :)

@jdneo
Copy link
Member

jdneo commented Feb 26, 2019

Considering the leetcode-cli is inactive for a long time. I'm thinking to fork and publish a temporary bit for it. Because currently there are too many issues blocked.

@poppinlp
Copy link
Contributor

@jdneo And maybe we should export a JS module instead of the CLI for easy using and performance reason.

@jdneo
Copy link
Member

jdneo commented Feb 26, 2019

@poppinlp That's exactly what I'm thinking.

But exporting a JS module might cost much more time, so in the short term, publishing a forked cli bit could be a workaround. For the long term, we need a library instead of depending on the cli.

@poppinlp
Copy link
Contributor

poppinlp commented Feb 26, 2019

@jdneo Agree. 👍

And if you like, maybe we could create a github org to contains the JS module, the CLI based on JS module, and extensions.
And i just find out that the owner of leetcode package name is a friend of me and it's long time inactive. So maybe we could use that package name. :)

@jdneo
Copy link
Member

jdneo commented Feb 26, 2019

@poppinlp Ok, let me think more about it and I'll let you know the update when I have more thoughts on this. Thank you for your passion. We can chat with more details in the gitter channel

@jdneo
Copy link
Member

jdneo commented Mar 3, 2019

Resolved in #179.

@jdneo jdneo closed this as completed Mar 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants