fix: freeze when opening a live-app [LIVE-13411] #7625
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
npx changeset
was attached.📝 Description
This fix (#7230) introduced a performance regression in some cases (e.g. when a lot of tokens are defined in the currencies field of the manifest) as we now get the currency list again and again.
This PR only removes the listing of currencies that we were doing on all apps even if it was not using the dapp browser v3, this helps most apps for the moment but we still need to improve the performance of the currency listing.
In a next PR we'll try to remove the spreading done on tokens, only do the minimal work necessary to get the informations and try to improve caching on this by instead listening to changes to only pull currencies when it updates.
❓ Context
🧐 Checklist for the PR Reviewers