fix(wallet-api): avoid caching listCurrencies result too early [LIVE-13205] #7230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 5 Ignored Deployments
|
live-github-bot
bot
added
desktop
Wozacosta
previously approved these changes
Jun 28, 2024
Wozacosta
reviewed
Jul 2, 2024
| } | ||
|
|
||
| if (!currencyList[0]) { | ||
| tracking.requestAccountFail(manifest); |
There was a problem hiding this comment.
Was that error tracking useless (since its being removed)?
Wozacosta
approved these changes
Jul 2, 2024
gre
approved these changes
Jul 2, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
npx changesetwas attached.📝 Description
Fix some tokens not showing in the wallet-api because we cached the listCurrencies at the start of the app and apparently some info are not yet available at that time
But we still have an issue if no accounts is present for a parent family no tokens will be loaded and present in our
currency.list❓ Context
🧐 Checklist for the PR Reviewers