-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: LIVE-13547 Replace expo-random lib with expo-crypto #7586
Merged
hzheng-ledger
merged 4 commits into
develop
from
bugfix/LIVE-13547-replace-expo-random-lib
Aug 14, 2024
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
b02dca8
fix: replace expo-random lib with expo-crypto
hzheng-ledger 70ed845
update expo-crypto version
hzheng-ledger 864ee58
Merge branch 'develop' into bugfix/LIVE-13547-replace-expo-random-lib
hzheng-ledger 1984c6a
fix: expo-crypto version
hzheng-ledger File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| --- | ||
| "@ledgerhq/coin-ton": patch | ||
| "live-mobile": patch | ||
| "@ledgerhq/live-common": patch | ||
| --- | ||
|
|
||
| fix: replace expo-random lib with expo-crypto |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -33,6 +33,8 @@ PODS: | |
| - ExpoModulesCore | ||
| - ZXingObjC/OneD | ||
| - ZXingObjC/PDF417 | ||
| - ExpoCrypto (12.8.1): | ||
| - ExpoModulesCore | ||
| - ExpoFileSystem (16.0.8): | ||
| - ExpoModulesCore | ||
| - ExpoImageManipulator (11.8.0): | ||
|
|
@@ -47,8 +49,6 @@ PODS: | |
| - React-NativeModulesApple | ||
| - React-RCTAppDelegate | ||
| - ReactCommon/turbomodule/core | ||
| - ExpoRandom (13.6.0): | ||
| - ExpoModulesCore | ||
| - FBLazyVector (0.73.6) | ||
| - FBReactNativeSpec (0.73.6): | ||
| - RCT-Folly (= 2022.05.16.00) | ||
|
|
@@ -1418,11 +1418,11 @@ DEPENDENCIES: | |
| - "EXImageLoader (from `../../../node_modules/.pnpm/[email protected][email protected][email protected]_@[email protected]_reac_wajnkpyn453mstvl5ptvmgckqi/node_modules/expo-image-loader/ios`)" | ||
| - "Expo (from `../../../node_modules/.pnpm/[email protected]_@[email protected]_@[email protected]_@[email protected]__expo-m_x6ekalzt4c5scoc72n5xqrun6q/node_modules/expo`)" | ||
| - "ExpoCamera (from `../../../node_modules/.pnpm/[email protected][email protected][email protected]_@[email protected]_react@18._7axu465aov6jwcuohjxifpffzu/node_modules/expo-camera/ios`)" | ||
| - "ExpoCrypto (from `../../../node_modules/.pnpm/[email protected][email protected][email protected]_@[email protected]_react@18._f3pw2vhdzqwifnm4jdvwei6rie/node_modules/expo-crypto/ios`)" | ||
| - "ExpoFileSystem (from `../../../node_modules/.pnpm/[email protected][email protected][email protected]_@[email protected]_reac_f2vophyguewptethhwrvhw6jze/node_modules/expo-file-system/ios`)" | ||
| - "ExpoImageManipulator (from `../../../node_modules/.pnpm/[email protected][email protected][email protected]_@[email protected]._sgbzbk7nfhtlihtns5cja4huei/node_modules/expo-image-manipulator/ios`)" | ||
| - "ExpoKeepAwake (from `../../../node_modules/.pnpm/[email protected][email protected][email protected]_@[email protected]_react_gqhplzyroote7enqgwhytprwhq/node_modules/expo-keep-awake/ios`)" | ||
| - "ExpoModulesCore (from `../../../node_modules/.pnpm/[email protected][email protected]_@[email protected][email protected][email protected]/node_modules/expo-modules-core`)" | ||
| - "ExpoRandom (from `../../../node_modules/.pnpm/[email protected][email protected][email protected]_@[email protected]_react@18._74hzmsxcfy4hq2gp3ztpqsecuu/node_modules/expo-random/ios`)" | ||
| - FBLazyVector (from `../node_modules/react-native/Libraries/FBLazyVector`) | ||
| - FBReactNativeSpec (from `../node_modules/react-native/React/FBReactNativeSpec`) | ||
| - Flipper (= 0.201.0) | ||
|
|
@@ -1605,6 +1605,8 @@ EXTERNAL SOURCES: | |
| :path: "../../../node_modules/.pnpm/[email protected]_@[email protected]_@[email protected]_@[email protected]__expo-m_x6ekalzt4c5scoc72n5xqrun6q/node_modules/expo" | ||
| ExpoCamera: | ||
| :path: "../../../node_modules/.pnpm/[email protected][email protected][email protected]_@[email protected]_react@18._7axu465aov6jwcuohjxifpffzu/node_modules/expo-camera/ios" | ||
| ExpoCrypto: | ||
| :path: "../../../node_modules/.pnpm/[email protected][email protected][email protected]_@[email protected]_react@18._f3pw2vhdzqwifnm4jdvwei6rie/node_modules/expo-crypto/ios" | ||
| ExpoFileSystem: | ||
| :path: "../../../node_modules/.pnpm/[email protected][email protected][email protected]_@[email protected]_reac_f2vophyguewptethhwrvhw6jze/node_modules/expo-file-system/ios" | ||
| ExpoImageManipulator: | ||
|
|
@@ -1613,8 +1615,6 @@ EXTERNAL SOURCES: | |
| :path: "../../../node_modules/.pnpm/[email protected][email protected][email protected]_@[email protected]_react_gqhplzyroote7enqgwhytprwhq/node_modules/expo-keep-awake/ios" | ||
| ExpoModulesCore: | ||
| :path: "../../../node_modules/.pnpm/[email protected][email protected]_@[email protected][email protected][email protected]/node_modules/expo-modules-core" | ||
| ExpoRandom: | ||
| :path: "../../../node_modules/.pnpm/[email protected][email protected][email protected]_@[email protected]_react@18._74hzmsxcfy4hq2gp3ztpqsecuu/node_modules/expo-random/ios" | ||
| FBLazyVector: | ||
| :path: "../node_modules/react-native/Libraries/FBLazyVector" | ||
| FBReactNativeSpec: | ||
|
|
@@ -1824,11 +1824,11 @@ SPEC CHECKSUMS: | |
| EXImageLoader: 55080616b2fe9da19ef8c7f706afd9814e279b6b | ||
| Expo: e01a77c6fa4bc80a6d1bb949cda1d12d21044abd | ||
| ExpoCamera: f3f157db67e5a491e1104a2c0018c240242936e7 | ||
| ExpoCrypto: b6428f48599c007676dc81a9b5f72c07e62fdccc | ||
| ExpoFileSystem: eecaf6796aed0f4dd20042dc2ca2cac6c4bc1185 | ||
| ExpoImageManipulator: c1d7cb865eacd620a35659f3da34c70531f10b59 | ||
| ExpoKeepAwake: 0f5cad99603a3268e50af9a6eb8b76d0d9ac956c | ||
| ExpoModulesCore: 61dc57c6e2a35f2f84baf488146db624e03af4cd | ||
| ExpoRandom: f0cd58e154e463d913462f3b445870b12d1c2f12 | ||
| FBLazyVector: f64d1e2ea739b4d8f7e4740cde18089cd97fe864 | ||
| FBReactNativeSpec: 7351d9daa8a692bc3af6eb00a56e4cdb07403431 | ||
| Firebase: 5f8193dff4b5b7c5d5ef72ae54bb76c08e2b841d | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not use the latest version (
13.0.2) ofexpo-crypto?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point.
In fact, I just take the same PR as zondax did. https://github.com/LedgerHQ/ledger-live/pull/7459/files
I will try with your suggestion, thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In fact,
in the new version of expo-crypto
the https://github.com/expo/expo/blob/main/packages/expo-crypto/android/build.gradle
is not compatible with our current android SDK version and it causes an error in CI.
it seems that the "useDefaultAndroidSdkVersions" needs a higher version of android SDK version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay too bad maybe we'll need to update that at some point with the next RN update