Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: LIVE-13547 Replace expo-random lib with expo-crypto #7586

Merged
merged 4 commits into from
Aug 14, 2024

Conversation

hzheng-ledger
Copy link
Contributor

@hzheng-ledger hzheng-ledger commented Aug 13, 2024

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes: No impact
    • ...

📝 Description

Replace the expo-random lib with expo-crypto
Same PR has been created by Zondax : #7459

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@hzheng-ledger hzheng-ledger requested review from a team as code owners August 13, 2024 09:05
Copy link

vercel bot commented Aug 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Aug 13, 2024 4:17pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Aug 13, 2024 4:17pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Aug 13, 2024 4:17pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Aug 13, 2024 4:17pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Aug 13, 2024 4:17pm

@live-github-bot live-github-bot bot added mobile Has changes in LLM common Has changes in live-common labels Aug 13, 2024
Copy link

socket-security bot commented Aug 13, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@ton/[email protected] None +2 847 kB mrmld
npm/[email protected] None 0 72.3 kB brentvatne

🚮 Removed packages: npm/@ton/[email protected], npm/[email protected]

View full report↗︎

Copy link
Contributor

@Justkant Justkant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small details

libs/ledger-live-common/package.json Outdated Show resolved Hide resolved
@@ -146,7 +146,7 @@
"expo-keep-awake": "~12.8.2",
"expo-modules-autolinking": "^1.10.2",
"expo-modules-core": "^1.11.8",
"expo-random": "^13.6.0",
"expo-crypto": "^12.8.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use the latest version (13.0.2) of expo-crypto ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point.
In fact, I just take the same PR as zondax did. https://github.com/LedgerHQ/ledger-live/pull/7459/files
I will try with your suggestion, thanks

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In fact,
in the new version of expo-crypto
the https://github.com/expo/expo/blob/main/packages/expo-crypto/android/build.gradle
is not compatible with our current android SDK version and it causes an error in CI.

it seems that the "useDefaultAndroidSdkVersions" needs a higher version of android SDK version.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay too bad maybe we'll need to update that at some point with the next RN update

@hzheng-ledger hzheng-ledger merged commit 94bf322 into develop Aug 14, 2024
56 of 58 checks passed
@hzheng-ledger hzheng-ledger deleted the bugfix/LIVE-13547-replace-expo-random-lib branch August 14, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common Has changes in live-common mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants