-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: LIVE-13547 Replace expo-random lib with expo-crypto #7586
Fix: LIVE-13547 Replace expo-random lib with expo-crypto #7586
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 5 Skipped Deployments
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@ton/[email protected], npm/[email protected] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small details
@@ -146,7 +146,7 @@ | |||
"expo-keep-awake": "~12.8.2", | |||
"expo-modules-autolinking": "^1.10.2", | |||
"expo-modules-core": "^1.11.8", | |||
"expo-random": "^13.6.0", | |||
"expo-crypto": "^12.8.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not use the latest version (13.0.2
) of expo-crypto
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point.
In fact, I just take the same PR as zondax did. https://github.com/LedgerHQ/ledger-live/pull/7459/files
I will try with your suggestion, thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In fact,
in the new version of expo-crypto
the https://github.com/expo/expo/blob/main/packages/expo-crypto/android/build.gradle
is not compatible with our current android SDK version and it causes an error in CI.
it seems that the "useDefaultAndroidSdkVersions" needs a higher version of android SDK version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay too bad maybe we'll need to update that at some point with the next RN update
✅ Checklist
npx changeset
was attached.📝 Description
Replace the expo-random lib with expo-crypto
Same PR has been created by Zondax : #7459
❓ Context
🧐 Checklist for the PR Reviewers