Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LIVE-13528 Chore/remove pivx code #7563

Merged
merged 14 commits into from
Aug 29, 2024
Merged

LIVE-13528 Chore/remove pivx code #7563

merged 14 commits into from
Aug 29, 2024

Conversation

Wozacosta
Copy link
Contributor

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

Replace this text by a clear and concise description of what this pull request is about and why it is needed. Be sure to explain the problem you're addressing and the solution you're proposing.
For libraries, you can add a code sample of how to use it.
For bugfixes, you can explain the previous behavior and how it was fixed.
In case of visual features, please attach screenshots or video recordings to demonstrate the changes.

❓ Context

  • JIRA or GitHub link: LIVE-13528

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@Wozacosta Wozacosta self-assigned this Aug 8, 2024
@vercel Vercel
Copy link

vercel bot commented Aug 8, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 27, 2024 4:07pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Aug 27, 2024 4:07pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Aug 27, 2024 4:07pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Aug 27, 2024 4:07pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Aug 27, 2024 4:07pm

@live-github-bot live-github-bot bot added desktop Has changes in LLD mobile Has changes in LLM common Has changes in live-common ledgerjs Has changes in the ledgerjs open source libs cli labels Aug 8, 2024
@Wozacosta Wozacosta marked this pull request as ready for review August 11, 2024 16:47
@Wozacosta Wozacosta requested review from a team as code owners August 11, 2024 16:47
gre
gre previously approved these changes Aug 12, 2024
View reviewed changes
Justkant
Justkant previously approved these changes Aug 12, 2024
View reviewed changes
Copy link
Contributor

@Justkant Justkant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to update the README for wallet-api too now

hzheng-ledger
hzheng-ledger reviewed Aug 12, 2024
View reviewed changes
libs/ledgerjs/packages/cryptoassets/src/currencies.ts
@@ -2088,42 +2088,6 @@ export const cryptocurrenciesById: Record<CryptoCurrencyId, CryptoCurrency> = {
},
],
},
pivx: {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we remove the pivx here?
AFAIK, we remove pivx support from Ledger-live. but the pivx nano app is still there.
i.e. we should give users a way to download the pivx nano app from Ledger Live manager.

hzheng-ledger
hzheng-ledger reviewed Aug 12, 2024
View reviewed changes
libs/ledgerjs/packages/types-cryptoassets/src/index.ts
@@ -81,7 +81,6 @@ export type CryptoCurrencyId =
| "particl"
| "persistence"
| "pirl"
| "pivx"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am wondering whether we should remove pivx in the ledgerjs package. because this package is used by other projects outside Ledger. This is why we see some LL unsupported currencies here. (e.g. monero)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI they were removed for peercoin, stealthcoin, vertcoin, viacoin
https://github.com/LedgerHQ/ledger-live/pull/7138/files#diff-8d5212f656c0023f496e2e16d624bfc345c426aa7f881b7b11b8dea43cf047ff
Was this a mistake also and do you think we should put them back in? Didn't seem to cause much trouble as no one complained but Im not 100% sure. In any case I'll put pivx back up
You make a good point about monero and the package usage outside of ledger live.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is true that peercoin, stealthcoin, vertcoin, viacoin have done the same thing. Maybe we can sync with product to make a decision.

@hzheng-ledger
Copy link
Contributor

Moreover, we can remove the "libs/ledger-live-common/explorers-config.md" file completely after my discussion with @gre

hzheng-ledger
hzheng-ledger requested changes Aug 12, 2024
View reviewed changes
Copy link
Contributor

@hzheng-ledger hzheng-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please have a look at my comments

@Wozacosta
Copy link
Contributor Author

Wozacosta commented Aug 13, 2024 •
edited
Loading

Moreover, we can remove the "libs/ledger-live-common/explorers-config.md" file completely after my discussion with @gre

@hzheng-ledger Do you have a link to the conv? Im assuming it's a legacy file that was automatically generated in an old process.

hzheng-ledger
hzheng-ledger previously approved these changes Aug 27, 2024
View reviewed changes
Copy link
Contributor

@hzheng-ledger hzheng-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

hzheng-ledger
hzheng-ledger approved these changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@hzheng-ledger hzheng-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@Wozacosta Wozacosta merged commit ef82161 into develop Aug 29, 2024
64 of 66 checks passed
@Wozacosta Wozacosta deleted the chore/remove-pivx-code branch August 29, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Justkant Justkant Justkant approved these changes

@hzheng-ledger hzheng-ledger hzheng-ledger approved these changes

@ypolishchuk-ledger ypolishchuk-ledger ypolishchuk-ledger approved these changes

@VicAlbr VicAlbr VicAlbr approved these changes

@gre gre gre left review comments

Assignees

@Wozacosta Wozacosta

Labels
cli common Has changes in live-common desktop Has changes in LLD ledgerjs Has changes in the ledgerjs open source libs mobile Has changes in LLM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Wozacosta @hzheng-ledger @gre @Justkant @ypolishchuk-ledger @VicAlbr