LIVE-13528 Chore/remove pivx code (#7563)

chore: remove pivx code
LedgerHQ · Aug 29, 2024 · ef82161 · ef82161
1 parent 741cc7a
commit ef82161
Show file tree

Hide file tree

Showing 40 changed files with 18 additions and 650 deletions.
diff --git a/.changeset/seven-parrots-listen.md b/.changeset/seven-parrots-listen.md
@@ -0,0 +1,14 @@
+---
+"@ledgerhq/types-cryptoassets": patch
+"@ledgerhq/cryptoassets": patch
+"@ledgerhq/coin-bitcoin": patch
+"ledger-live-desktop": patch
+"live-mobile": patch
+"@ledgerhq/live-common": patch
+"@ledgerhq/live-countervalues": patch
+"@ledgerhq/coin-framework": patch
+"@ledgerhq/web-tools": patch
+"@ledgerhq/live-cli": patch
+---
+
+remove pivx code
diff --git a/apps/cli/src/live-common-setup-base.ts b/apps/cli/src/live-common-setup-base.ts
@@ -34,7 +34,6 @@ setSupportedCurrencies([
   "qtum",
   "bitcoin_gold",
   "komodo",
-  "pivx",
   "zencash",
   "bitcoin_testnet",
   "ethereum_sepolia",

diff --git a/apps/ledger-live-desktop/src/live-common-set-supported-currencies.ts b/apps/ledger-live-desktop/src/live-common-set-supported-currencies.ts
@@ -42,7 +42,6 @@ setSupportedCurrencies([
   "qtum",
   "bitcoin_gold",
   "komodo",
-  "pivx",
   "zencash",
   "bitcoin_testnet",
   "ethereum_sepolia",

diff --git a/apps/ledger-live-desktop/tests/mocks/serviceStatusHelpers.ts b/apps/ledger-live-desktop/tests/mocks/serviceStatusHelpers.ts
@@ -342,21 +342,6 @@ const statuses = {
       group: false,
       only_show_if_degraded: false,
     },
-    {
-      id: "44xfftm0ztkq",
-      name: "Pivx (PIVX)",
-      status: "operational",
-      created_at: "2020-06-22T17:55:04.800+02:00",
-      updated_at: "2021-01-14T22:42:40.068+01:00",
-      position: 14,
-      description: null,
-      showcase: true,
-      start_date: null,
-      group_id: "rn7ny8423ghs",
-      page_id: "767c5rcj7z12",
-      group: false,
-      only_show_if_degraded: false,
-    },
     {
       id: "t40n3pwhqqbq",
       name: "Qtum (QTUM)",

diff --git a/...sktop/tests/specs/services/wallet-api.spec.ts-snapshots/wallet-api-currencies-darwin.json b/...sktop/tests/specs/services/wallet-api.spec.ts-snapshots/wallet-api-currencies-darwin.json
@@ -341,15 +341,6 @@
     "color": "#326464",
     "decimals": 8
   },
-  {
-    "type": "CryptoCurrency",
-    "id": "pivx",
-    "ticker": "PIVX",
-    "name": "PivX",
-    "family": "bitcoin",
-    "color": "#46385d",
-    "decimals": 8
-  },
   {
     "type": "CryptoCurrency",
     "id": "zencash",

diff --git a/...esktop/tests/specs/services/wallet-api.spec.ts-snapshots/wallet-api-currencies-linux.json b/...esktop/tests/specs/services/wallet-api.spec.ts-snapshots/wallet-api-currencies-linux.json
@@ -341,15 +341,6 @@
     "color": "#326464",
     "decimals": 8
   },
-  {
-    "type": "CryptoCurrency",
-    "id": "pivx",
-    "ticker": "PIVX",
-    "name": "PivX",
-    "family": "bitcoin",
-    "color": "#46385d",
-    "decimals": 8
-  },
   {
     "type": "CryptoCurrency",
     "id": "zencash",

diff --git a/apps/ledger-live-mobile/__mocks__/api/market/coinsList.json b/apps/ledger-live-mobile/__mocks__/api/market/coinsList.json
@@ -8553,7 +8553,6 @@
   { "id": "pitch-fxs", "symbol": "pitchfxs", "name": "Pitch FXS" },
   { "id": "piteas", "symbol": "pts", "name": "Piteas" },
   { "id": "pivn", "symbol": "pivn", "name": "PIVN" },
-  { "id": "pivx", "symbol": "pivx", "name": "PIVX" },
   { "id": "pixel-battle", "symbol": "pwc", "name": "Pixel Battle" },
   { "id": "pixelpotus", "symbol": "pxl", "name": "PixelPotus" },
   { "id": "pixelverse", "symbol": "pixel", "name": "PixelVerse" },

diff --git a/apps/ledger-live-mobile/android/dapp-store/config.yaml b/apps/ledger-live-mobile/android/dapp-store/config.yaml
@@ -95,7 +95,7 @@ release:
         Tron (TRX), Polygon (MATIC), Ethereum Classic (ETC), Dash (DASH), Cosmos
         (ATOM), Elrond (EGLD), Zcash (ZEC), Dogecoin (DOGE), Digibyte (DGB),
         Bitcoin Gold (BTG), Decred (DCR), Qtum (QTUM), Algorand (ALGO), Komodo
-        (KMD), Horizen (ZEN), PivX (PIVX), Stakenet (XSN), ERC-20 and BEP-20 tokens.
+        (KMD), Horizen (ZEN), Stakenet (XSN), ERC-20 and BEP-20 tokens.
 
 
 

diff --git a/apps/ledger-live-mobile/src/live-common-setup.ts b/apps/ledger-live-mobile/src/live-common-setup.ts
@@ -74,7 +74,6 @@ setSupportedCurrencies([
   "qtum",
   "bitcoin_gold",
   "komodo",
-  "pivx",
   "zencash",
   "bitcoin_testnet",
   "ethereum_sepolia",

diff --git a/apps/ledger-live-mobile/src/newArch/features/Web3Hub/utils/api/mocks/manifests.ts b/apps/ledger-live-mobile/src/newArch/features/Web3Hub/utils/api/mocks/manifests.ts
@@ -90,7 +90,6 @@ export const mocks: AppManifest[] = [
       "qtum",
       "bitcoin_gold",
       "komodo",
-      "pivx",
       "zencash",
       "vertcoin",
       "peercoin",

diff --git a/apps/ledger-live-mobile/src/screens/Settings/Debug/__mocks__/serviceStatus.ts b/apps/ledger-live-mobile/src/screens/Settings/Debug/__mocks__/serviceStatus.ts
@@ -343,21 +343,6 @@ const statuses = {
       group: false,
       only_show_if_degraded: false,
     },
-    {
-      id: "44xfftm0ztkq",
-      name: "Pivx (PIVX)",
-      status: "operational",
-      created_at: "2020-06-22T17:55:04.800+02:00",
-      updated_at: "2021-01-14T22:42:40.068+01:00",
-      position: 14,
-      description: null,
-      showcase: true,
-      start_date: null,
-      group_id: "rn7ny8423ghs",
-      page_id: "767c5rcj7z12",
-      group: false,
-      only_show_if_degraded: false,
-    },
     {
       id: "t40n3pwhqqbq",
       name: "Qtum (QTUM)",

diff --git a/apps/web-tools/live-common-setup.ts b/apps/web-tools/live-common-setup.ts
@@ -46,7 +46,6 @@ setSupportedCurrencies([
   "qtum",
   "bitcoin_gold",
   "komodo",
-  "pivx",
   "zencash",
   "bitcoin_testnet",
   "ethereum_sepolia",

diff --git a/libs/coin-framework/src/currencies/__snapshots__/formatCurrencyUnit.test.ts.snap b/libs/coin-framework/src/currencies/__snapshots__/formatCurrencyUnit.test.ts.snap
@@ -226,8 +226,6 @@ exports[`formatCurrencyUnit with custom options with locale de-DE should correct
 
 exports[`formatCurrencyUnit with custom options with locale de-DE should correctly format Pirl unit (PIRL) 1`] = `"123.456.789,00000000- -PIRL"`;
 
-exports[`formatCurrencyUnit with custom options with locale de-DE should correctly format PivX unit (pivx) 1`] = `"123.456.789,00000000- -PIVX"`;
-
 exports[`formatCurrencyUnit with custom options with locale de-DE should correctly format Polkadot unit (DOT) 1`] = `"1.234.567,8900000000- -DOT"`;
 
 exports[`formatCurrencyUnit with custom options with locale de-DE should correctly format Polygon unit (MATIC) 1`] = `"0,012345678900000000- -MATIC"`;
@@ -552,8 +550,6 @@ exports[`formatCurrencyUnit with custom options with locale en-US should correct
 
 exports[`formatCurrencyUnit with custom options with locale en-US should correctly format Pirl unit (PIRL) 1`] = `"123,456,789.00000000- -PIRL"`;
 
-exports[`formatCurrencyUnit with custom options with locale en-US should correctly format PivX unit (pivx) 1`] = `"123,456,789.00000000- -PIVX"`;
-
 exports[`formatCurrencyUnit with custom options with locale en-US should correctly format Polkadot unit (DOT) 1`] = `"1,234,567.8900000000- -DOT"`;
 
 exports[`formatCurrencyUnit with custom options with locale en-US should correctly format Polygon unit (MATIC) 1`] = `"0.012345678900000000- -MATIC"`;
@@ -878,8 +874,6 @@ exports[`formatCurrencyUnit with custom options with locale es-ES should correct
 
 exports[`formatCurrencyUnit with custom options with locale es-ES should correctly format Pirl unit (PIRL) 1`] = `"123.456.789,00000000- -PIRL"`;
 
-exports[`formatCurrencyUnit with custom options with locale es-ES should correctly format PivX unit (pivx) 1`] = `"123.456.789,00000000- -PIVX"`;
-
 exports[`formatCurrencyUnit with custom options with locale es-ES should correctly format Polkadot unit (DOT) 1`] = `"1.234.567,8900000000- -DOT"`;
 
 exports[`formatCurrencyUnit with custom options with locale es-ES should correctly format Polygon unit (MATIC) 1`] = `"0,012345678900000000- -MATIC"`;
@@ -1204,8 +1198,6 @@ exports[`formatCurrencyUnit with custom options with locale fr-FR should correct
 
 exports[`formatCurrencyUnit with custom options with locale fr-FR should correctly format Pirl unit (PIRL) 1`] = `"123 456 789,00000000- -PIRL"`;
 
-exports[`formatCurrencyUnit with custom options with locale fr-FR should correctly format PivX unit (pivx) 1`] = `"123 456 789,00000000- -PIVX"`;
-
 exports[`formatCurrencyUnit with custom options with locale fr-FR should correctly format Polkadot unit (DOT) 1`] = `"1 234 567,8900000000- -DOT"`;
 
 exports[`formatCurrencyUnit with custom options with locale fr-FR should correctly format Polygon unit (MATIC) 1`] = `"0,012345678900000000- -MATIC"`;
@@ -1530,8 +1522,6 @@ exports[`formatCurrencyUnit with custom options with locale ja-JP should correct
 
 exports[`formatCurrencyUnit with custom options with locale ja-JP should correctly format Pirl unit (PIRL) 1`] = `"123,456,789.00000000- -PIRL"`;
 
-exports[`formatCurrencyUnit with custom options with locale ja-JP should correctly format PivX unit (pivx) 1`] = `"123,456,789.00000000- -PIVX"`;
-
 exports[`formatCurrencyUnit with custom options with locale ja-JP should correctly format Polkadot unit (DOT) 1`] = `"1,234,567.8900000000- -DOT"`;
 
 exports[`formatCurrencyUnit with custom options with locale ja-JP should correctly format Polygon unit (MATIC) 1`] = `"0.012345678900000000- -MATIC"`;
@@ -1856,8 +1846,6 @@ exports[`formatCurrencyUnit with custom options with locale ko-KR should correct
 
 exports[`formatCurrencyUnit with custom options with locale ko-KR should correctly format Pirl unit (PIRL) 1`] = `"123,456,789.00000000- -PIRL"`;
 
-exports[`formatCurrencyUnit with custom options with locale ko-KR should correctly format PivX unit (pivx) 1`] = `"123,456,789.00000000- -PIVX"`;
-
 exports[`formatCurrencyUnit with custom options with locale ko-KR should correctly format Polkadot unit (DOT) 1`] = `"1,234,567.8900000000- -DOT"`;
 
 exports[`formatCurrencyUnit with custom options with locale ko-KR should correctly format Polygon unit (MATIC) 1`] = `"0.012345678900000000- -MATIC"`;
@@ -2182,8 +2170,6 @@ exports[`formatCurrencyUnit with custom options with locale pt-BR should correct
 
 exports[`formatCurrencyUnit with custom options with locale pt-BR should correctly format Pirl unit (PIRL) 1`] = `"123.456.789,00000000- -PIRL"`;
 
-exports[`formatCurrencyUnit with custom options with locale pt-BR should correctly format PivX unit (pivx) 1`] = `"123.456.789,00000000- -PIVX"`;
-
 exports[`formatCurrencyUnit with custom options with locale pt-BR should correctly format Polkadot unit (DOT) 1`] = `"1.234.567,8900000000- -DOT"`;
 
 exports[`formatCurrencyUnit with custom options with locale pt-BR should correctly format Polygon unit (MATIC) 1`] = `"0,012345678900000000- -MATIC"`;
@@ -2508,8 +2494,6 @@ exports[`formatCurrencyUnit with custom options with locale ru-RU should correct
 
 exports[`formatCurrencyUnit with custom options with locale ru-RU should correctly format Pirl unit (PIRL) 1`] = `"123 456 789,00000000- -PIRL"`;
 
-exports[`formatCurrencyUnit with custom options with locale ru-RU should correctly format PivX unit (pivx) 1`] = `"123 456 789,00000000- -PIVX"`;
-
 exports[`formatCurrencyUnit with custom options with locale ru-RU should correctly format Polkadot unit (DOT) 1`] = `"1 234 567,8900000000- -DOT"`;
 
 exports[`formatCurrencyUnit with custom options with locale ru-RU should correctly format Polygon unit (MATIC) 1`] = `"0,012345678900000000- -MATIC"`;
@@ -2834,8 +2818,6 @@ exports[`formatCurrencyUnit with custom options with locale tr-TR should correct
 
 exports[`formatCurrencyUnit with custom options with locale tr-TR should correctly format Pirl unit (PIRL) 1`] = `"123.456.789,00000000- -PIRL"`;
 
-exports[`formatCurrencyUnit with custom options with locale tr-TR should correctly format PivX unit (pivx) 1`] = `"123.456.789,00000000- -PIVX"`;
-
 exports[`formatCurrencyUnit with custom options with locale tr-TR should correctly format Polkadot unit (DOT) 1`] = `"1.234.567,8900000000- -DOT"`;
 
 exports[`formatCurrencyUnit with custom options with locale tr-TR should correctly format Polygon unit (MATIC) 1`] = `"0,012345678900000000- -MATIC"`;
@@ -3160,8 +3142,6 @@ exports[`formatCurrencyUnit with custom options with locale zh-CN should correct
 
 exports[`formatCurrencyUnit with custom options with locale zh-CN should correctly format Pirl unit (PIRL) 1`] = `"123,456,789.00000000- -PIRL"`;
 
-exports[`formatCurrencyUnit with custom options with locale zh-CN should correctly format PivX unit (pivx) 1`] = `"123,456,789.00000000- -PIVX"`;
-
 exports[`formatCurrencyUnit with custom options with locale zh-CN should correctly format Polkadot unit (DOT) 1`] = `"1,234,567.8900000000- -DOT"`;
 
 exports[`formatCurrencyUnit with custom options with locale zh-CN should correctly format Polygon unit (MATIC) 1`] = `"0.012345678900000000- -MATIC"`;
@@ -3486,8 +3466,6 @@ exports[`formatCurrencyUnit with default options should correctly format Persist
 
 exports[`formatCurrencyUnit with default options should correctly format Pirl unit (PIRL) 1`] = `"123,456,789"`;
 
-exports[`formatCurrencyUnit with default options should correctly format PivX unit (pivx) 1`] = `"123,456,789"`;
-
 exports[`formatCurrencyUnit with default options should correctly format Polkadot unit (DOT) 1`] = `"1,234,567"`;
 
 exports[`formatCurrencyUnit with default options should correctly format Polygon unit (MATIC) 1`] = `"0.0123456"`;

diff --git a/libs/coin-modules/coin-bitcoin/.unimportedrc.json b/libs/coin-modules/coin-bitcoin/.unimportedrc.json
@@ -18,7 +18,6 @@
     "src/datasets/dogecoin.ts",
     "src/datasets/litecoin.scanAccounts.1.ts",
     "src/datasets/litecoin.ts",
-    "src/datasets/pivx.ts",
     "src/datasets/zcash.ts",
     "src/datasets/zencash.ts",
     "src/descriptor.ts",

diff --git a/libs/coin-modules/coin-bitcoin/src/bridge.integration.ts b/libs/coin-modules/coin-bitcoin/src/bridge.integration.ts
@@ -11,7 +11,6 @@ import digibyte from "./datasets/digibyte";
 import dogecoin from "./datasets/dogecoin";
 import zencash from "./datasets/zencash";
 import litecoin from "./datasets/litecoin";
-import pivx from "./datasets/pivx";
 import zcash from "./datasets/zcash";
 
 /*
@@ -41,7 +40,6 @@ export const dataset: DatasetTest<Transaction> = {
     dogecoin,
     zencash,
     litecoin,
-    pivx,
     zcash,
   },
 };

diff --git a/libs/coin-modules/coin-bitcoin/src/datasets/pivx.ts b/libs/coin-modules/coin-bitcoin/src/datasets/pivx.ts
diff --git a/libs/coin-modules/coin-bitcoin/src/logic.ts b/libs/coin-modules/coin-bitcoin/src/logic.ts
@@ -19,7 +19,6 @@ import type { Account, Operation, OperationType } from "@ledgerhq/types-live";
 const minFees: Partial<Record<CryptoCurrencyId | "LBRY" | "groestcoin" | "osmo", number>> = {
   bitcoin: 1000,
   bitcoin_gold: 1000,
-  pivx: 2000,
   qtum: 4000,
   stratis: 2000,
 };

diff --git a/libs/coin-modules/coin-bitcoin/src/networks.ts b/libs/coin-modules/coin-bitcoin/src/networks.ts
@@ -213,20 +213,6 @@ export const getNetworkParameters = (networkName: string): BitcoinLikeNetworkPar
       sigHash: BitcoinLikeSigHashType.SIGHASH_ALL,
       additionalBIPs: [],
     };
-  } else if (networkName === "pivx") {
-    return {
-      identifier: "pivx",
-      P2PKHVersion: Buffer.from([0x1e]),
-      P2SHVersion: Buffer.from([0x0d]),
-      xpubVersion: Buffer.from([0x02, 0x2d, 0x25, 0x33]),
-      feePolicy: BitcoinLikeFeePolicy.PER_BYTE,
-      dustAmount: new BigNumber(10000),
-      messagePrefix: "DarkNet Signed Message:\n",
-      usesTimestampedTransaction: false,
-      timestampDelay: new BigNumber(0),
-      sigHash: BitcoinLikeSigHashType.SIGHASH_ALL,
-      additionalBIPs: [],
-    };
   } else if (networkName === "clubcoin") {
     return {
       identifier: "club",

diff --git a/libs/coin-modules/coin-bitcoin/src/specs.ts b/libs/coin-modules/coin-bitcoin/src/specs.ts
@@ -394,20 +394,6 @@ const bitcoinCash: AppSpec<Transaction> = {
   minViableAmount: genericMinimalAmount,
 };
 
-const pivx: AppSpec<Transaction> = {
-  name: "PivX",
-  currency: getCryptoCurrencyById("pivx"),
-  dependency: "Bitcoin Legacy",
-  appQuery: {
-    model: DeviceModelId.nanoS,
-    appName: "PivX",
-    appVersion: "2.1.0-rc",
-  },
-  genericDeviceAction: acceptTransaction,
-  test: genericTest,
-  mutations: bitcoinLikeMutations(),
-  minViableAmount: genericMinimalAmount,
-};
 const minQtum = parseCurrencyUnit(getCryptoCurrencyById("qtum").units[0], "0.001");
 const qtum: AppSpec<Transaction> = {
   name: "Qtum",
@@ -573,7 +559,6 @@ export default {
   dogecoin,
   komodo,
   litecoin,
-  pivx,
   qtum,
   zcash,
   zencash,

diff --git a/libs/coin-modules/coin-bitcoin/src/wallet-btc/__tests__/utils.test.ts b/libs/coin-modules/coin-bitcoin/src/wallet-btc/__tests__/utils.test.ts
@@ -140,7 +140,6 @@ describe("Unit tests for various utils functions", () => {
     validateAddrs(["D8cMCRimfjwQ9E8jJvgUswt18WnZbCUAaW"], "dogecoin", true);
     validateAddrs(["dgb1q7zjgqa23xzf602ljfrc94248a9u27xml08nhct"], "digibyte", true);
     validateAddrs(["REnTkuvjsmfshAZ3vukYfuS3ZGvfUatqFc"], "komodo", true);
-    validateAddrs(["DQ7F2iTQn6kUpyvietinaC3Cxje2m1ULjS"], "pivx", true);
     validateAddrs(["zndVnjbrzRxvhPGRea4jgsfSWE1hXFja1dc"], "zencash", true);
     validateAddrs(["Dso59DoPRkfATcZgHGgfh9mpku7taw9srAv"], "decred", true);
     validateAddrs(["Dcck4QrFF5wuLzQpwxb5evhSRD7ZTsJZwuh"], "decred", true);
@@ -159,7 +158,6 @@ describe("Unit tests for various utils functions", () => {
     validateAddrs(["D8cMCRimfjwQ9E8jJvgUswt18WnZbCUAaa"], "dogecoin", false);
     validateAddrs(["dgb1q7zjgqa23xzf602ljfrc94248a9u27xml08nhcc"], "digibyte", false);
     validateAddrs(["REnTkuvjsmfshAZ3vukYfuS3ZGvfUatqFF"], "komodo", false);
-    validateAddrs(["DQ7F2iTQn6kUpyvietinaC3Cxje2m1ULjj"], "pivx", false);
     validateAddrs(["zndVnjbrzRxvhPGRea4jgsfSWE1hXFja1dd"], "zencash", false);
     validateAddrs(["Dso59DoPRkfATcZgHGgff9mpku7taw9srAv"], "decred", false);
     validateAddrs(["Dcck4QrFF5wuLQzpwxb5evhSRD7ZTsJZwuh"], "decred", false);

diff --git a/libs/coin-modules/coin-bitcoin/src/wallet-btc/__tests__/xpub.syncing.integration.test.ts b/libs/coin-modules/coin-bitcoin/src/wallet-btc/__tests__/xpub.syncing.integration.test.ts
@@ -126,14 +126,6 @@ describe("xpub integration sync", () => {
       network: coininfo.bitcoin.main.toBitcoinJS(),
       currencyId: "komodo",
     },
-    {
-      xpub: "ToEA6kVVodfRW2DuuMjPPMsLLukY4EsScxdHYJkTtdopPD5Z5t9gpB2zEwpschy7rFzTqxQCXQFUBnxT5MAnfkNT4dkWqtHPE2L7bG7GC24XnLy",
-      derivationMode: DerivationModes.LEGACY,
-      addresses: 1,
-      balance: 400000000,
-      network: coininfo.bitcoin.main.toBitcoinJS(),
-      currencyId: "pivx",
-    },
     {
       xpub: "dpubZFUiMExUREbqJQVJkfXSs4wjUb1jwVkoofnPK8Mt95j3PanCyq9Mc4aFnWtRZkhci9ZYPVLZybVLMMkS6g1nKBTN4899KJwGeVBvyumvcjW",
       derivationMode: DerivationModes.LEGACY,