Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix standard plugin build with ledger_assert #507

Merged
merged 3 commits into from
Dec 6, 2023
Merged

Fix standard plugin build with ledger_assert #507

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
180f321
Fixed plugin SDK compatibility with ledger_assert
apaillier-ledger Dec 5, 2023
0f2d026
Renamed plugin SDK utils to plugin_utils to prevent filename conflict…
apaillier-ledger Dec 6, 2023
6c1567a
Updated plugin SDK changelog
apaillier-ledger Dec 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion src_plugin_sdk/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,25 @@
| :rotating_light: | Breaks build |
| :warning: | Breaks compatibility with app |

## [latest](/) - 2023/10/19
## [latest](/) - 2023/12/06

### Fixed

* standard\_plugin build ([this PR on the SDK](https://github.com/LedgerHQ/ledger-secure-sdk/pull/473) had broken it)

### Changed

* utils renamed to plugin\_utils to prevent filename conflicts in plugins

## [4d8e044](/../../commit/4d8e044) - 2023/11/09

### Added

* standard\_plugin Makefile so plugins can use it & have a really small Makefile
with only the relevant information
* Comments in the plugin interface header file

## [1fe4085](/../../commit/1fe4085) - 2023/10/19

### Changed

Expand Down
2 changes: 1 addition & 1 deletion src_plugin_sdk/utils.c → src_plugin_sdk/plugin_utils.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
* limitations under the License.
*****************************************************************************/

#include "utils.h"
#include "plugin_utils.h"

bool find_selector(uint32_t selector, const uint32_t *array, size_t size, size_t *idx) {
for (size_t i = 0; i < size; ++i) {
Expand Down
0 src_plugin_sdk/utils.h → src_plugin_sdk/plugin_utils.h
View file
Open in desktop
File renamed without changes.
2 changes: 2 additions & 0 deletions src_plugin_sdk/standard_plugin.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,8 @@ DISABLE_STANDARD_SNPRINTF = 1
DISABLE_STANDARD_USB = 1
DISABLE_STANDARD_WEBUSB = 1
DISABLE_STANDARD_BAGL_UX_FLOW = 1
DISABLE_DEBUG_LEDGER_ASSERT = 1
DISABLE_DEBUG_THROW = 1

# Required for PRINTFs to compile
ifeq ($(DEBUG),0)
Expand Down
4 changes: 2 additions & 2 deletions tools/build_sdk.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,8 +210,8 @@ def merge_c_files(sources, nodes_to_extract):

files_to_copy = [
"main.c",
"utils.c",
"utils.h",
"plugin_utils.c",
"plugin_utils.h",
]
for file in files_to_copy:
shutil.copyfile("src_plugin_sdk/" + file,
Expand Down
Loading