Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix standard plugin build with ledger_assert #507

Merged
merged 3 commits into from
Dec 6, 2023
Merged

Fix standard plugin build with ledger_assert #507

merged 3 commits into from
Dec 6, 2023

Conversation

apaillier-ledger
Copy link
Contributor

Description

Fix standard plugin build that recently broke with LedgerHQ/ledger-secure-sdk#473

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Tests
  • Documentation
  • Other (for changes that might not fit in any category)

@apaillier-ledger apaillier-ledger force-pushed the fix/apa/standard_plugin_mk_with_ledger_assert branch 2 times, most recently from 7a0814f to f37fc19 Compare December 6, 2023 14:14
@apaillier-ledger apaillier-ledger force-pushed the fix/apa/standard_plugin_mk_with_ledger_assert branch from f37fc19 to 6c1567a Compare December 6, 2023 14:20
@apaillier-ledger apaillier-ledger merged commit 70cc0a8 into develop Dec 6, 2023
88 of 93 checks passed
@apaillier-ledger apaillier-ledger deleted the fix/apa/standard_plugin_mk_with_ledger_assert branch December 6, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbeutin-ledger fbeutin-ledger fbeutin-ledger approved these changes

Assignees

@apaillier-ledger apaillier-ledger

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apaillier-ledger @fbeutin-ledger