Skip to content

Conversation

@stevennevins
Copy link
Contributor

No description provided.

@stevennevins stevennevins changed the base branch from mainnet to dev June 26, 2024 15:05
@stevennevins stevennevins mentioned this pull request Jun 26, 2024
3 tasks
Copy link
Collaborator

@ypatil12 ypatil12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments

* @param operator The address of the operator to deregister.
*/
function deregisterOperatorFromAVS(address operator) public virtual onlyRegistryCoordinator {
function deregisterOperatorFromAVS(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we still implement this function in our canonical example?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gotcha. Were we envisioning that we would only have operator sets going forward, or support two ServiceManager contracts?

* The off-chain service should do that validation separately
*/
function getRestakeableStrategies() external view returns (address[] memory) {
function getRestakeableStrategies()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need this function anymore for operator set based AVSs, since this is provided via the MetadataURI

view
returns (address[] memory)
{
function getOperatorRestakedStrategies(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed for operator set release, since computed via operator<>operatorSet indexing along with metadataURI

@stevennevins stevennevins changed the title feat: operator sets update feat: operator-sets-3-registration Aug 7, 2024
@stevennevins
Copy link
Contributor Author

closed in favor of #301

@stevennevins stevennevins deleted the feat/operatorsets-steven branch August 19, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants