-
Notifications
You must be signed in to change notification settings - Fork 114
feat: operator-sets-3-registration #279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments
| * @param operator The address of the operator to deregister. | ||
| */ | ||
| function deregisterOperatorFromAVS(address operator) public virtual onlyRegistryCoordinator { | ||
| function deregisterOperatorFromAVS( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we still implement this function in our canonical example?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gotcha. Were we envisioning that we would only have operator sets going forward, or support two ServiceManager contracts?
| * The off-chain service should do that validation separately | ||
| */ | ||
| function getRestakeableStrategies() external view returns (address[] memory) { | ||
| function getRestakeableStrategies() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need this function anymore for operator set based AVSs, since this is provided via the MetadataURI
| view | ||
| returns (address[] memory) | ||
| { | ||
| function getOperatorRestakedStrategies( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not needed for operator set release, since computed via operator<>operatorSet indexing along with metadataURI
|
closed in favor of #301 |
No description provided.