Skip to content

Conversation

@8sunyuan
Copy link
Collaborator

@8sunyuan 8sunyuan commented Jun 3, 2024

Disregard the changed files not in /src, changes were only made to make all contracts build

TODO before merge:

  • Draft OperatorSets implementation with migration flow
  • Unit tests
  • Update core-repo submodule import to use actual IOperatorSetManager interface once a agreed upon POC is complete

@8sunyuan
Copy link
Collaborator Author

8sunyuan commented Jun 4, 2024

Noting that RegistryCoordinator contract size is exceeding limit and some refactoring will be required.

image

@8sunyuan
Copy link
Collaborator Author

8sunyuan commented Jun 5, 2024

Noting that the isOperatorMigrated mapping in ServiceManagerBaseStorage may not be required if the OperatorSetManager contract is the AVSDirectory.

Assuming some new mapping is used for the view function OperatorSetManager.isOperatorInOperatorSet.
When operators are migrating registration, we can require they are not in the operator set but their avsOperatorStatus is registered.

/*******************************************************************************
OperatorSetManager Interface
*******************************************************************************/
/**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: import from eigenlayer-contracts

for (uint256 j = 0; j < numStrategies; ++j) {
IStrategy strategy = _stakeRegistry.strategyParamsByIndex(i, j).strategy;
strategies[j] = strategy;
require(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we just not check this at all and have the call to OSM revert?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also works assuming it will revert

@stevennevins
Copy link
Contributor

Closing in favor of #279

@stevennevins stevennevins deleted the feat/operator-sets branch September 30, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants