PatternClips now use startTimeOffset, too, and can be resized on their start#6584
Conversation
|
Tested on W10-64. It works ok. |
DomClark
left a comment
There was a problem hiding this comment.
Thanks for the pull request! This looks really useful. I've left a few comments on the code - feel free to quibble them if you think I'm talking nonsense, or ask for more detail if I haven't been clear enough.
342dc12 to
feade45
Compare
feade45 to
c57cdd4
Compare
|
build fails should be fixed with this |
99c2664 to
ff81abe
Compare
ff81abe to
7f9ca12
Compare
Veratil
left a comment
There was a problem hiding this comment.
Just some naming thoughts. Feel free to ignore for merge.
7f9ca12 to
af05b77
Compare
af05b77 to
7a9ee0b
Compare
|
Final fix from my side. |
|
CMake Error at scripts/cmake/vcpkg_download_distfile.cmake:32 (message): Failed to download file with error: 1
In future vcpkg releases, if you are using Windows, you no longer need to set Otherwise, please submit an issue at https://github.com/Microsoft/vcpkg/issues Call Stack (most recent call first): |
|
@ToastedSadWitch since the vcpkg error isn't something on our side we can ignore that. :) |
I checked the gui part, playback, export, copying and storing.
When dropping a pattern clip with startTimeOffset into another pattern clip, the startTimeOffset is currently not copied. If this is no wanted behaviour, please tell me, so I can try to fix it.
Also the behaviour of resizing the start is faulty sometimes when colliding with the start of the song editor (clip may grow or there is a padding sometimes). As this also happens on the sample track, it seems to be a general deal with ResizeLeft action.
This commit is for issue #6346.