Code

Recording after rebase to master#4994

Code

Closed

Reflexe wants to merge 112 commits intoLMMS:masterLMMS/lmms:masterfrom Reflexe:recording_rebased_to_masterReflexe/lmms:recording_rebased_to_masterCopy head branch name to clipboard

+3,352-2,232

Commits

Commits on May 26, 2019

• SampleTrack: Uncomment disabled recording-related code.

  Reflexe

  committed
  8fd89ee

  Copy full SHA for 8fd89ee

• SampleTrack: Fix TCO not being played on the first tick (if it starts on

  Show description for e86fd69
  Reflexe

  committed
  e86fd69

  Copy full SHA for e86fd69

• AudioJack: Basic implementation of capture (without AUDIO_PORT_SUPPORT)

  Reflexe

  committed
  34eb63c

  Copy full SHA for 34eb63c

• Mixer & PlayHandle: Support PlayHandle without audioPort and set

  Show description for 1720fcd
  Reflexe

  committed
  1720fcd

  Copy full SHA for 1720fcd

• Mixer -> pushInputFrames: Add an option to automaticly normalize input

  Show description for 7074ac8
  Reflexe

  committed
  7074ac8

  Copy full SHA for 7074ac8

• AudioPulseAudio: Switch playback sample type to float and add capture

  Show description for 86eb13f
  Reflexe

  committed
  86eb13f

  Copy full SHA for 86eb13f

• Track -> SampleTrack: Do not save start time offset for empty

  Show description for 45a484a
  Reflexe

  committed
  45a484a

  Copy full SHA for 45a484a

• AudioJack: Allocate and deallocate m_tempInBufs.

  Reflexe

  committed
  c4b69a3

  Copy full SHA for c4b69a3

• SampleTrack: Make sure an empty TCO with isRecord would still be

  Show description for 0a9debc
  Reflexe

  committed
  0a9debc

  Copy full SHA for 0a9debc

• SampleTrack: Reset the start time offset when importing a new

  Show description for f72c5d9
  Reflexe

  committed
  f72c5d9

  Copy full SHA for f72c5d9

• SampleRecordHandle: Apply start offset to reocrded TCO.

  Show description for 5241b4b
  Reflexe

  committed
  5241b4b

  Copy full SHA for 5241b4b

• Track, TrackView: Instead of trying every possible dynamic_cast in

  Show description for 55029bd
  Reflexe

  committed
  55029bd

  Copy full SHA for 55029bd

• SampleTrack Recording: Add per SampleTrack and a global fallback for the

  Show description for 5229868
  Reflexe

  committed
  5229868

  Copy full SHA for 5229868

• Editor -> Style: Reorder editor buttons.

  Reflexe

  committed
  e290203

  Copy full SHA for e290203

• SampleTrack -> RecordingChannel: Remove the default option, instead, all

  Show description for 48fea61
  Reflexe

  committed
  48fea61

  Copy full SHA for 48fea61

• SampleTrack: Change recordingChannel menu label.

  Reflexe

  committed
  6feeb4a

  Copy full SHA for 6feeb4a

• SampleTrack: In a case of recording, play a sample TCO even if its

  Show description for 1bb14b5
  Reflexe

  committed
  1bb14b5

  Copy full SHA for 1bb14b5

• SampleRecordHandle: Obtain the offset to the record with a parameter

  Show description for cbd669c
  Reflexe

  committed
  cbd669c

  Copy full SHA for cbd669c

• AudioJack: Fix a deadblock on exporting a sample with different sample

  Show description for ef9d9e8
  Reflexe

  committed
  ef9d9e8

  Copy full SHA for ef9d9e8

• SongEditor: Hide the global channel selection toolbox when capture

  Show description for 31a69dd
  Reflexe

  committed
  31a69dd

  Copy full SHA for 31a69dd

• SongEditor: Hide the record button.

  Reflexe

  committed
  52eef80

  Copy full SHA for 52eef80

• Bugfix - SampleTrack -> Load & Save: Fix recorded sample track not being

  Show description for 1e9845f
  Reflexe

  committed
  1e9845f

  Copy full SHA for 1e9845f

• Bugfix - SampleTrack -> Play: Fix sample track not being played in the

  Show description for 7b49167
  Reflexe

  committed
  7b49167

  Copy full SHA for 7b49167

• SampleTrack -> Recording: Enable per-track record setting and

  Show description for 333ba57
  Reflexe

  committed
  333ba57

  Copy full SHA for 333ba57

• SampleTrack: On project save, save the values of SampleTrack::m_record

  Show description for 16dc30b
  Reflexe

  committed
  16dc30b

  Copy full SHA for 16dc30b

• SampleTrack -> Minor: Reorder the constructor initialization order to

  Show description for 0b2d8a7
  Reflexe

  committed
  0b2d8a7

  Copy full SHA for 0b2d8a7

• Travis: Use SDL2 on Windows.

  Reflexe

  committed
  75f84d6

  Copy full SHA for 75f84d6

• Travis -> InstallRaw: Fix Shellcheck warnings.

  Reflexe

  committed
  70f2046

  Copy full SHA for 70f2046

• Travis -> Linux: Use SDL2 by default.

  Reflexe

  committed
  96ccbfe

  Copy full SHA for 96ccbfe

• CMake -> Install: Install SDL2.dll instead of SDL.dll.

  Show description for 5f68c8b
  Reflexe

  committed
  5f68c8b

  Copy full SHA for 5f68c8b

• AudioJack: Connect capture stream to LMMS by default.

  Reflexe

  committed
  acc1b8e

  Copy full SHA for acc1b8e

• AudioSdl -> Recording - Bugfix: Due to spec.sampleRate being wrong,

  Show description for 715778f
  Reflexe

  committed
  715778f

  Copy full SHA for 715778f

• Style -> SampleTrack Recording: Paint recorded sampletrack red (intead

  Show description for 79cddac
  Reflexe

  committed
  79cddac

  Copy full SHA for 79cddac

• basics: Change sampleFrame to std::array<sample_t, DEFAULT_CHANNELS>

  Show description for c881c14
  Reflexe

  committed
  c881c14

  Copy full SHA for c881c14

• SampleBuffer: Internally change buffer to std::vector and support

  Show description for 84cea2b
  Reflexe

  committed
  84cea2b

  Copy full SHA for 84cea2b

• SampleRecordHandle and SampleTrack: Support in-recording updating and

  Show description for f394a59
  Reflexe

  committed
  f394a59

  Copy full SHA for f394a59

• SampleBuffer: Work around compilation error with libsamplerate 0.1.8

  Show description for e47cdd2
  Reflexe

  committed
  e47cdd2

  Copy full SHA for e47cdd2

• Recording and SampleTrack: Remove setSampleBuffer and introduce

  Show description for ad3a03e
  Reflexe

  committed
  ad3a03e

  Copy full SHA for ad3a03e

• MemoryManager: Add == and != operators for MmAllocator.

  Reflexe

  committed
  7e9a578

  Copy full SHA for 7e9a578

• Recording: Don't apply masterGain for input frames.

  Reflexe

  committed
  ee5981d

  Copy full SHA for ee5981d

• SampleTCO -> recording: Export is_record attribute for future loading.

  Reflexe

  committed
  7118380

  Copy full SHA for 7118380

• SampleBuffer: fix resampleing error: null output data.

  Reflexe

  committed
  d588c56

  Copy full SHA for d588c56

• Cleanup for next commit: Remove the unused AudioSampleRecorder.

  Reflexe

  committed
  1b7660d

  Copy full SHA for 1b7660d

• SampleBuffer: Remove the god function "update" and split it into a

  Show description for a5b684c
  Reflexe

  committed
  a5b684c

  Copy full SHA for a5b684c

• Mixer: Fix another crash with play handle without an audioPort.

  Reflexe

  committed
  53d3b4c

  Copy full SHA for 53d3b4c

• SampleRecordHandle: Tell mixer to remove us when we done. With

  Show description for c615235
  Reflexe

  committed
  c615235

  Copy full SHA for c615235

• AudioPortAudio: Support recording.

  Reflexe

  committed
  58314a4

  Copy full SHA for 58314a4

• SampleTrack: Move per-track slots from SampleTCO to SampleTrack.

  Reflexe

  committed
  0aab43a

  Copy full SHA for 0aab43a

• Song -> Recording with loop: support creating of recording tcos in

  Show description for c39ccbb
  Reflexe

  committed
  c39ccbb

  Copy full SHA for c39ccbb

• SampleRecordHandle: Fix a bug when even when not recording, a track set

  Show description for 3d9efbb
  Reflexe

  committed
  3d9efbb

  Copy full SHA for 3d9efbb

• SampleBuffer -> Samplerate - Fix two sample rate issues:

  Show description for f4a70a7
  Reflexe

  committed
  f4a70a7

  Copy full SHA for f4a70a7

• AudioJack: Use std::vector for buffer

  Show description for b1ffa19
  Reflexe

  committed
  b1ffa19

  Copy full SHA for b1ffa19

• SampleBuffer: Don't use sharedObject

  Show description for 210423f
  Reflexe

  committed
  210423f

  Copy full SHA for 210423f

• SampleBuffer: Use JournallingObject

  Show description for 90c9b74
  Reflexe

  committed
  90c9b74

  Copy full SHA for 90c9b74

• SampleBuffer: Don't normalize any SampleBuffer's sample rate to the

  Show description for 79c20bc
  Reflexe

  committed
  79c20bc

  Copy full SHA for 79c20bc

• Windows -> Recording: Enable jack.

  Reflexe

  committed
  a26a8df

  Copy full SHA for a26a8df

• Travis: Install jack on win32 builds for its headers.

  Reflexe

  committed
  196f000

  Copy full SHA for 196f000

Commits on May 27, 2019

• Song: Fix loops and recording.

  Reflexe

  committed
  d0385d6

  Copy full SHA for d0385d6

• Win32 Installer -> Jack: Try to bundle jack installer.

  Reflexe

  committed
  0132e33

  Copy full SHA for 0132e33

• Support Jack on Windows + Bundled jack Installer (#6)

  Reflexe

  committed
  2ccd530

  Copy full SHA for 2ccd530

• SampleBuffer: Use resetData instead of beginBufferChange when

  Show description for ab9a2a3
  Reflexe

  committed
  ab9a2a3

  Copy full SHA for ab9a2a3

• SampleBuffer: Make frames() thread-safe.

  Reflexe

  committed
  8166e95

  Copy full SHA for 8166e95

• SampleBuffer & SampleTCOView: Cache visualization while recording.

  Reflexe

  committed
  0ba71ca

  Copy full SHA for 0ba71ca

• PulseAudio: Disable recording since it produces voices from hell.

  Reflexe

  committed
  a356e78

  Copy full SHA for a356e78

• AudioSdl: Disable recording in linux since it have a very high latency

  Show description for 6fe3267
  Reflexe

  committed
  6fe3267

  Copy full SHA for 6fe3267

• SampleTrack: Avoid crashes while recording by locking the mixer before

  Show description for 3a43158
  Reflexe

  committed
  3a43158

  Copy full SHA for 3a43158

• SampleTrackView: Fix visualization not being cleared between recording

  Show description for a056dfb
  Reflexe

  committed
  a056dfb

  Copy full SHA for a056dfb

• SamplePlayHandle: Fix export issues by correctly calculating

  Show description for d11c826
  Reflexe

  committed
  d11c826

  Copy full SHA for d11c826

• SampleTCOView: Implement caching for visualization.

  Reflexe

  committed
  09f0b0d

  Copy full SHA for 09f0b0d

• SampleTCO -> Recording: Block resize and move actions while recording.

  Reflexe

  committed
  d2d8bd7

  Copy full SHA for d2d8bd7

• SampleBuffer -> SoundFile: Support mono files, show a warning for

  Show description for b1fed89
  Reflexe

  committed
  b1fed89

  Copy full SHA for b1fed89

• SampleBuffer -> Recording: Use less blocking locks with addData and

  Show description for b5123e6
  Reflexe

  committed
  b5123e6

  Copy full SHA for b5123e6

• SampleBuffer: Fix mono sample decoding

  Show description for 8121812
  

  lukas-w

  authored and

  Reflexe

  committed
  8121812

  Copy full SHA for 8121812

• SampleBuffer::play: Fix freq factor calculation

  Show description for a4efebc
  

  lukas-w

  authored and

  Reflexe

  committed
  a4efebc

  Copy full SHA for a4efebc

• Remove bundled Jack headers, use system headers instead

  

  lukas-w

  authored and

  Reflexe

  committed
  013d9f4

  Copy full SHA for 013d9f4

• CMake: Fix finding jack when cross-compiling with non-standard CMake

  Show description for 46d2233
  

  lukas-w

  authored and

  Reflexe

  committed
  46d2233

  Copy full SHA for 46d2233

• Fix PatMan patch loading

  Show description for 67d5c77
  

  PhysSong

  authored and

  Reflexe

  committed
  67d5c77

  Copy full SHA for 67d5c77

• Fix setting sample buffer name

  Show description for b6b61eb
  

  PhysSong

  authored and

  Reflexe

  committed
  b6b61eb

  Copy full SHA for b6b61eb

• Use CMake's file command to download JACK installer

  

  PhysSong

  authored and

  Reflexe

  committed
  7d8d130

  Copy full SHA for 7d8d130

• MmAllocator: add missing constructors

  

  PhysSong

  authored and

  Reflexe

  committed
  21b9569

  Copy full SHA for 21b9569

• Improve JACK finding logic

  Show description for 8200efb
  

  PhysSong

  authored and

  Reflexe

  committed
  8200efb

  Copy full SHA for 8200efb

• Don't try to resample empty data

  

  PhysSong

  authored and

  Reflexe

  committed
  dd04ef7

  Copy full SHA for dd04ef7

• Fix remaining file name reset issues

  

  PhysSong

  authored and

  Reflexe

  committed
  60cf294

  Copy full SHA for 60cf294

• Fix JACK installer download

  Show description for e98b133
  

  PhysSong

  authored and

  Reflexe

  committed
  e98b133

  Copy full SHA for e98b133

• Improve JACK installation on Windows

  Show description for 2175eac
  

  PhysSong

  authored and

  Reflexe

  committed
  2175eac

  Copy full SHA for 2175eac

• SampleBuffer: Don't treat an empty file as an error

  Reflexe

  committed
  6e76182

  Copy full SHA for 6e76182

• Bugfix -> SampleBuffer: To avoid arithmetic exception, userWaveSample

  Show description for ca9be24
  Reflexe

  committed
  ca9be24

  Copy full SHA for ca9be24

• Bugfix -> SampleBuffer: Don't unlock the mixer when it has not been locked.

  Reflexe

  committed
  1c9b53a

  Copy full SHA for 1c9b53a

• SampleBuffer: Disable automatic up-sampling to the mixer's sample rate.

  Show description for 6ee074d
  Reflexe

  committed
  6ee074d

  Copy full SHA for 6ee074d

• Fix TripleOscillator preset previewing due to nonexistent waveform files

  

  PhysSong

  authored and

  Reflexe

  committed
  87239ac

  Copy full SHA for 87239ac

• SampleBuffer: use the RAII pattern when changing its data

  Show description for 283625c
  

  PhysSong

  authored and

  Reflexe

  committed
  283625c

  Copy full SHA for 283625c

• LmmsBasics: Move LoopMode here from SampleBuffer.

  Reflexe

  committed
  3a47ded

  Copy full SHA for 3a47ded

• Mixer: Introduce RequestChangesGuard: a RAII verion of

  Show description for e206254
  Reflexe

  committed
  e206254

  Copy full SHA for e206254

• SampleBuffer: Seperate the class into 3 internal classes.

  Show description for 5cfc4a3
  Reflexe

  committed
  5cfc4a3

  Copy full SHA for 5cfc4a3

• Oscillator: include lmms_math.h.

  Reflexe

  committed
  d65c1d0

  Copy full SHA for d65c1d0

• Introduce Threading.h and runAsync: std::async using

  Show description for 00acb14
  Reflexe

  committed
  00acb14

  Copy full SHA for 00acb14

• Introduce UpdatingValue: thread-safe automatically updated value.

  Reflexe

  committed
  aac5600

  Copy full SHA for aac5600

• Mixer: Add runWhileNotRendering helper.

  Reflexe

  committed
  4082d78

  Copy full SHA for 4082d78

• Engine: Delete the mixer last in order to be able to use requestChanges

  Show description for 67186e2
  Reflexe

  committed
  67186e2

  Copy full SHA for 67186e2

• SampleBufferPlayInfo: Add m_maybeAudiofile.

  Reflexe

  committed
  6f36515

  Copy full SHA for 6f36515

• Track::createTCO: avoid creating tcos while rendering.

  Show description for 0f8c6d6
  Reflexe

  committed
  0f8c6d6

  Copy full SHA for 0f8c6d6

• SampleBuffer: Make setX functions async, remove get functions

  Show description for 855b070
  Reflexe

  committed
  855b070

  Copy full SHA for 855b070

• SampleBuffer & SampleTCO visualization: visualize async only

  Show description for 8dc1475
  Reflexe

  committed
  8dc1475

  Copy full SHA for 8dc1475

• Track: put mixer syncs in tco remove/add in order to avoid

  Show description for 1c42efa
  Reflexe

  committed
  1c42efa

  Copy full SHA for 1c42efa

• SampleRecordHandle: move calls to SampleBuffer's methods

  Show description for 98d1062
  Reflexe

  committed
  98d1062

  Copy full SHA for 98d1062

• SampleRecordHandle: Add guard before setting startRecordTimeOffset

  Show description for cd6ad7a
  Reflexe

  committed
  cd6ad7a

  Copy full SHA for cd6ad7a

• Threading: Add runAccordingToLaunchType helper that will run

  Show description for 7d8fdff
  Reflexe

  committed
  7d8fdff

  Copy full SHA for 7d8fdff

• SampleBuffer: Support setX sync operation instead of only async.

  Reflexe

  committed
  cde4baa

  Copy full SHA for cde4baa

• SampleTrack: use sync version of SampleBuffer's setX in order to avoid

  Show description for ab180b0
  Reflexe

  committed
  ab180b0

  Copy full SHA for ab180b0

• Use LMMS_EXPORT in order to resolve MSVC problems.

  Reflexe

  committed
  91c6e96

  Copy full SHA for 91c6e96

• SampleTrack -> QMutex: use tryLock instead of tryLock.

  Reflexe

  committed
  a7236e4

  Copy full SHA for a7236e4

• AudioFileProcessor: fix saving/loading problems.

  Reflexe

  committed
  444e638

  Copy full SHA for 444e638