-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recording after rebase to master #4994
Commits on May 26, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 8fd89ee - Browse repository at this point
Copy the full SHA 8fd89eeView commit details -
Configuration menu - View commit details
-
Copy full SHA for e86fd69 - Browse repository at this point
Copy the full SHA e86fd69View commit details -
Configuration menu - View commit details
-
Copy full SHA for 34eb63c - Browse repository at this point
Copy the full SHA 34eb63cView commit details -
Mixer & PlayHandle: Support PlayHandle without audioPort and set
audioPort as nullptr by default.
Configuration menu - View commit details
-
Copy full SHA for 1720fcd - Browse repository at this point
Copy the full SHA 1720fcdView commit details -
Mixer -> pushInputFrames: Add an option to automaticly normalize input
frames by the masterGain.
Configuration menu - View commit details
-
Copy full SHA for 7074ac8 - Browse repository at this point
Copy the full SHA 7074ac8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 86eb13f - Browse repository at this point
Copy the full SHA 86eb13fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 45a484a - Browse repository at this point
Copy the full SHA 45a484aView commit details -
Configuration menu - View commit details
-
Copy full SHA for c4b69a3 - Browse repository at this point
Copy the full SHA c4b69a3View commit details -
SampleTrack: Make sure an empty TCO with isRecord would still be
"played" (recorded).
Configuration menu - View commit details
-
Copy full SHA for 0a9debc - Browse repository at this point
Copy the full SHA 0a9debcView commit details -
SampleTrack: Reset the start time offset when importing a new
SampleBuffer. That solves problem with recording that caused samples to be moved and messed up. Thanks @-BaraMGB for helping.
Configuration menu - View commit details
-
Copy full SHA for f72c5d9 - Browse repository at this point
Copy the full SHA f72c5d9View commit details -
SampleRecordHandle: Apply start offset to reocrded TCO.
Previously, begining record in any position would result the data being in the end of the TCO. @see LMMS#3947 (comment) Thanks to @-BaraMGB :)
Configuration menu - View commit details
-
Copy full SHA for 5241b4b - Browse repository at this point
Copy the full SHA 5241b4bView commit details -
Track, TrackView: Instead of trying every possible
dynamic_cast
in`updateMenu`, use a virtual function overriden by every Track implemetation.
Configuration menu - View commit details
-
Copy full SHA for 55029bd - Browse repository at this point
Copy the full SHA 55029bdView commit details -
SampleTrack Recording: Add per SampleTrack and a global fallback for the
input channel configurations. And support recording of one channel and converting it to two. The user would be able to set their input config per track, or globally. For each recorded sampletrack, the recorded will get the channel config and will duplicate the samples from one channel to the other in a case of mono input.
Configuration menu - View commit details
-
Copy full SHA for 5229868 - Browse repository at this point
Copy the full SHA 5229868View commit details -
Configuration menu - View commit details
-
Copy full SHA for e290203 - Browse repository at this point
Copy the full SHA e290203View commit details -
SampleTrack -> RecordingChannel: Remove the default option, instead, all
options unchecked will be considered as global default. Suggested by @-tresf, Thanks!
Configuration menu - View commit details
-
Copy full SHA for 48fea61 - Browse repository at this point
Copy the full SHA 48fea61View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6feeb4a - Browse repository at this point
Copy the full SHA 6feeb4aView commit details -
SampleTrack: In a case of recording, play a sample TCO even if its
actual data starts after that.
Configuration menu - View commit details
-
Copy full SHA for 1bb14b5 - Browse repository at this point
Copy the full SHA 1bb14b5View commit details -
SampleRecordHandle: Obtain the offset to the record with a parameter
instead of hacking sampleBuffer ()->startFrame (). That solves a bug with `startFrame ()` being negetive in recording some cases.
Configuration menu - View commit details
-
Copy full SHA for cbd669c - Browse repository at this point
Copy the full SHA cbd669cView commit details -
AudioJack: Fix a deadblock on exporting a sample with different sample
rate. The deadblock was caused by the mixer stopping which make the recording thread to wait until it get started again and in the other side, the exporting thread which wants to acquire a mutex that had been locked by the recording thread. Many thanks to PhysSong :)
Configuration menu - View commit details
-
Copy full SHA for ef9d9e8 - Browse repository at this point
Copy the full SHA ef9d9e8View commit details -
SongEditor: Hide the global channel selection toolbox when capture
support is not available. Thanks to @-Sawuare.
Configuration menu - View commit details
-
Copy full SHA for 31a69dd - Browse repository at this point
Copy the full SHA 31a69ddView commit details -
Configuration menu - View commit details
-
Copy full SHA for 52eef80 - Browse repository at this point
Copy the full SHA 52eef80View commit details -
Bugfix - SampleTrack -> Load & Save: Fix recorded sample track not being
played correctly after saving and loading a project due to sample rate not getting saved in the project file.
Configuration menu - View commit details
-
Copy full SHA for 1e9845f - Browse repository at this point
Copy the full SHA 1e9845fView commit details -
Bugfix - SampleTrack -> Play: Fix sample track not being played in the
right place when it not played from the begining. That has created a difference between the ticks and the metronome and the sample track. The cause of the problem was that the calculation of the frame to play was wrong: we had calculated `framesPerTick` according to the current engine's sample rate instead of the SampleBuffer's sample rate.
Configuration menu - View commit details
-
Copy full SHA for 7b49167 - Browse repository at this point
Copy the full SHA 7b49167View commit details -
SampleTrack -> Recording: Enable per-track record setting and
automaticlly create "record sample tco" if there is no recording tco. This commit adds per-track record setting. If a sample track is set as record, lmms will check if there is a tco that set to record: * If there is, it will record into it. * If there is not, it will create a special tco that get created on recording, and as long as the recording.
Configuration menu - View commit details
-
Copy full SHA for 333ba57 - Browse repository at this point
Copy the full SHA 333ba57View commit details -
SampleTrack: On project save, save the values of SampleTrack::m_record
and SampleTrack::m_recordingChannel.
Configuration menu - View commit details
-
Copy full SHA for 16dc30b - Browse repository at this point
Copy the full SHA 16dc30bView commit details -
SampleTrack -> Minor: Reorder the constructor initialization order to
avoid a warning. Thanks to @-PhysSong.
Configuration menu - View commit details
-
Copy full SHA for 0b2d8a7 - Browse repository at this point
Copy the full SHA 0b2d8a7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 75f84d6 - Browse repository at this point
Copy the full SHA 75f84d6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 70f2046 - Browse repository at this point
Copy the full SHA 70f2046View commit details -
Configuration menu - View commit details
-
Copy full SHA for 96ccbfe - Browse repository at this point
Copy the full SHA 96ccbfeView commit details -
CMake -> Install: Install SDL2.dll instead of SDL.dll.
Many thanks to @-PhysSong.
Configuration menu - View commit details
-
Copy full SHA for 5f68c8b - Browse repository at this point
Copy the full SHA 5f68c8bView commit details -
Configuration menu - View commit details
-
Copy full SHA for acc1b8e - Browse repository at this point
Copy the full SHA acc1b8eView commit details -
AudioSdl -> Recording - Bugfix: Due to spec.sampleRate being wrong,
recording would stop early
Configuration menu - View commit details
-
Copy full SHA for 715778f - Browse repository at this point
Copy the full SHA 715778fView commit details -
Style -> SampleTrack Recording: Paint recorded sampletrack red (intead
of writing "Rec").
Configuration menu - View commit details
-
Copy full SHA for 79cddac - Browse repository at this point
Copy the full SHA 79cddacView commit details -
basics: Change sampleFrame to
std::array<sample_t, DEFAULT_CHANNELS>
in order to make stantard containers be able to store it.
Configuration menu - View commit details
-
Copy full SHA for c881c14 - Browse repository at this point
Copy the full SHA c881c14View commit details -
Configuration menu - View commit details
-
Copy full SHA for 84cea2b - Browse repository at this point
Copy the full SHA 84cea2bView commit details -
SampleRecordHandle and SampleTrack: Support in-recording updating and
visualizing of a SampleTCO. SampleRecordHandle: Instead of adding buffers to a list and then joining it to new SampleBuffer. Add the in-recording to the new SampleBuffer. SampleTCOView: Make sure our SampleBuffer is not locked, if it is, skip this frame and flag it for update. Also make sure we're getting updated for a changes from SampleBuffer::sampleUpdated.
Configuration menu - View commit details
-
Copy full SHA for f394a59 - Browse repository at this point
Copy the full SHA f394a59View commit details -
SampleBuffer: Work around compilation error with libsamplerate 0.1.8
See the HACK comment
Configuration menu - View commit details
-
Copy full SHA for e47cdd2 - Browse repository at this point
Copy the full SHA e47cdd2View commit details -
Recording and SampleTrack: Remove setSampleBuffer and introduce
resetData. That solves a race condition when one thread calls sampleBuffer() and it gets destructed by another thread that calls setSampleBuffer.
Configuration menu - View commit details
-
Copy full SHA for ad3a03e - Browse repository at this point
Copy the full SHA ad3a03eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7e9a578 - Browse repository at this point
Copy the full SHA 7e9a578View commit details -
Configuration menu - View commit details
-
Copy full SHA for ee5981d - Browse repository at this point
Copy the full SHA ee5981dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7118380 - Browse repository at this point
Copy the full SHA 7118380View commit details -
Configuration menu - View commit details
-
Copy full SHA for d588c56 - Browse repository at this point
Copy the full SHA d588c56View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1b7660d - Browse repository at this point
Copy the full SHA 1b7660dView commit details -
SampleBuffer: Remove the god function "update" and split it into a
number of functions: - beginBufferChange, doneBufferChange: Guards for direct access to m_data. They will also resample the data if it is needed. Functions like `addData` will check additional parameter to know if we should lock the mixer in this context. - Add reverse and remove the attribute m_reversed: The only user was AudioFileProcessor and it added complexity for the file loading process. Right now we'll just `reverse` the buffer manually. - changeAudioFile: Will reset the current buffer and load a file into it. - Remove the raw constructor `SampleBuffer(sampleFrame*, f_cnt_t)`: It was used only once and could easily be converted to another constructor.
Configuration menu - View commit details
-
Copy full SHA for a5b684c - Browse repository at this point
Copy the full SHA a5b684cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 53d3b4c - Browse repository at this point
Copy the full SHA 53d3b4cView commit details -
SampleRecordHandle: Tell mixer to remove us when we done. With
isFinished (when possible). That will solve our "never ending recording after tco finishing" problem :)
Configuration menu - View commit details
-
Copy full SHA for c615235 - Browse repository at this point
Copy the full SHA c615235View commit details -
Configuration menu - View commit details
-
Copy full SHA for 58314a4 - Browse repository at this point
Copy the full SHA 58314a4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0aab43a - Browse repository at this point
Copy the full SHA 0aab43aView commit details -
Configuration menu - View commit details
-
Copy full SHA for c39ccbb - Browse repository at this point
Copy the full SHA c39ccbbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3d9efbb - Browse repository at this point
Copy the full SHA 3d9efbbView commit details -
SampleBuffer -> Samplerate - Fix two sample rate issues:
1. Resampling was the wrong (src_rate was invalid) 2. SampleBuffer was using baseSampleRate as the default samplerate instead of the actual processingSampleRate.
Configuration menu - View commit details
-
Copy full SHA for f4a70a7 - Browse repository at this point
Copy the full SHA f4a70a7View commit details -
AudioJack: Use std::vector for buffer
Improve performance by using std::vector::resize instead of deleting and reallocating every time. LmmsBasics: Add static asserts to make sure no padding is added to sampleFrame by std::array. Thanks to @-lukas-w!
Configuration menu - View commit details
-
Copy full SHA for b1ffa19 - Browse repository at this point
Copy the full SHA b1ffa19View commit details -
SampleBuffer: Don't use sharedObject
Don't use sharedObject. It does not make any sense and could lead to bugs when allocated locally (see audio_file_processor). When needed, this commit used std::shared_ptr which was made for that.
Configuration menu - View commit details
-
Copy full SHA for 210423f - Browse repository at this point
Copy the full SHA 210423fView commit details -
SampleBuffer: Use JournallingObject
Exporting and restoring is universally done now by saveSettings and loadSettings. That's allows us to make sure we don't left any important attributes like "sampleRate" behind
Configuration menu - View commit details
-
Copy full SHA for 90c9b74 - Browse repository at this point
Copy the full SHA 90c9b74View commit details -
SampleBuffer: Don't normalize any SampleBuffer's sample rate to the
Mixer's processing rate. That could lead to ireversable sample loss. Now we'll only resample when it needed and the processing sample rate is higher than the buffer's sample rate. Thanks to @-PhySong for pointing it out!
Configuration menu - View commit details
-
Copy full SHA for 79c20bc - Browse repository at this point
Copy the full SHA 79c20bcView commit details -
Configuration menu - View commit details
-
Copy full SHA for a26a8df - Browse repository at this point
Copy the full SHA a26a8dfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 196f000 - Browse repository at this point
Copy the full SHA 196f000View commit details
Commits on May 27, 2019
-
Configuration menu - View commit details
-
Copy full SHA for d0385d6 - Browse repository at this point
Copy the full SHA d0385d6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0132e33 - Browse repository at this point
Copy the full SHA 0132e33View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2ccd530 - Browse repository at this point
Copy the full SHA 2ccd530View commit details -
Configuration menu - View commit details
-
Copy full SHA for ab9a2a3 - Browse repository at this point
Copy the full SHA ab9a2a3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8166e95 - Browse repository at this point
Copy the full SHA 8166e95View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0ba71ca - Browse repository at this point
Copy the full SHA 0ba71caView commit details -
Configuration menu - View commit details
-
Copy full SHA for a356e78 - Browse repository at this point
Copy the full SHA a356e78View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6fe3267 - Browse repository at this point
Copy the full SHA 6fe3267View commit details -
SampleTrack: Avoid crashes while recording by locking the mixer before
making any changes in the track.
Configuration menu - View commit details
-
Copy full SHA for 3a43158 - Browse repository at this point
Copy the full SHA 3a43158View commit details -
SampleTrackView: Fix visualization not being cleared between recording
sessions and handle sample start offset properly.
Configuration menu - View commit details
-
Copy full SHA for a056dfb - Browse repository at this point
Copy the full SHA a056dfbView commit details -
SamplePlayHandle: Fix export issues by correctly calculating
totalFrames. Many thanks to @-PhySong. What a great find.
Configuration menu - View commit details
-
Copy full SHA for d11c826 - Browse repository at this point
Copy the full SHA d11c826View commit details -
Configuration menu - View commit details
-
Copy full SHA for 09f0b0d - Browse repository at this point
Copy the full SHA 09f0b0dView commit details -
Configuration menu - View commit details
-
Copy full SHA for d2d8bd7 - Browse repository at this point
Copy the full SHA d2d8bd7View commit details -
Configuration menu - View commit details
-
Copy full SHA for b1fed89 - Browse repository at this point
Copy the full SHA b1fed89View commit details -
SampleBuffer -> Recording: Use less blocking locks with addData and
resetData. I've added two new methods: * tryAddData * tryResetData Which do the same, but without locking. If we've failed to lock, no problem, just wait until the next time.
Configuration menu - View commit details
-
Copy full SHA for b5123e6 - Browse repository at this point
Copy the full SHA b5123e6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8121812 - Browse repository at this point
Copy the full SHA 8121812View commit details -
SampleBuffer::play: Fix freq factor calculation
Fixes regression from f765773 (presumably a copy/paste mistake)
Configuration menu - View commit details
-
Copy full SHA for a4efebc - Browse repository at this point
Copy the full SHA a4efebcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 013d9f4 - Browse repository at this point
Copy the full SHA 013d9f4View commit details -
CMake: Fix finding jack when cross-compiling with non-standard CMake
Thanks to @-PhysSong.
Configuration menu - View commit details
-
Copy full SHA for 46d2233 - Browse repository at this point
Copy the full SHA 46d2233View commit details -
Fixes a regression in 84a1f35.
Configuration menu - View commit details
-
Copy full SHA for 67d5c77 - Browse repository at this point
Copy the full SHA 67d5c77View commit details -
Fix setting sample buffer name
Fixes a regression in 7bc0056 that breaks showing file names.
Configuration menu - View commit details
-
Copy full SHA for b6b61eb - Browse repository at this point
Copy the full SHA b6b61ebView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7d8d130 - Browse repository at this point
Copy the full SHA 7d8d130View commit details -
Configuration menu - View commit details
-
Copy full SHA for 21b9569 - Browse repository at this point
Copy the full SHA 21b9569View commit details -
* Enable WeakJACK only if JACK is available. * Try `pkg_check_modules` first when using WeakJACK, too.
Configuration menu - View commit details
-
Copy full SHA for 8200efb - Browse repository at this point
Copy the full SHA 8200efbView commit details -
Configuration menu - View commit details
-
Copy full SHA for dd04ef7 - Browse repository at this point
Copy the full SHA dd04ef7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 60cf294 - Browse repository at this point
Copy the full SHA 60cf294View commit details -
Fixes a regression in 063b7c9.
Configuration menu - View commit details
-
Copy full SHA for e98b133 - Browse repository at this point
Copy the full SHA e98b133View commit details -
Improve JACK installation on Windows
* Bundle 64-bit version of JACK for 64-bit installer. * Change some CMake logic for NSIS
Configuration menu - View commit details
-
Copy full SHA for 2175eac - Browse repository at this point
Copy the full SHA 2175eacView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6e76182 - Browse repository at this point
Copy the full SHA 6e76182View commit details -
Bugfix -> SampleBuffer: To avoid arithmetic exception, userWaveSample
should return with empty buffer.
Configuration menu - View commit details
-
Copy full SHA for ca9be24 - Browse repository at this point
Copy the full SHA ca9be24View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1c9b53a - Browse repository at this point
Copy the full SHA 1c9b53aView commit details -
SampleBuffer: Disable automatic up-sampling to the mixer's sample rate.
Since it may cause quality loss, we have decided to remove it and just use on-the-fly resampling while playing.
Configuration menu - View commit details
-
Copy full SHA for 6ee074d - Browse repository at this point
Copy the full SHA 6ee074dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 87239ac - Browse repository at this point
Copy the full SHA 87239acView commit details -
SampleBuffer: use the RAII pattern when changing its data
Also renames misleading `shouldLockMixer` to `syncWithMixer`.
Configuration menu - View commit details
-
Copy full SHA for 283625c - Browse repository at this point
Copy the full SHA 283625cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3a47ded - Browse repository at this point
Copy the full SHA 3a47dedView commit details -
Mixer: Introduce
RequestChangesGuard
: a RAII verion ofrequestChangeInModel. Deprecate direct calls to requestChangeInModel.
Configuration menu - View commit details
-
Copy full SHA for e206254 - Browse repository at this point
Copy the full SHA e206254View commit details -
SampleBuffer: Seperate the class into 3 internal classes.
- SampleBufferData: Responsible for audio data. - SampleBufferFileHelper: Responsible for loading audio files. - SampleBufferPlayInfo: Responsible for holding information such as startFrame, etc. This commit also removes `m_varLock` and guards all getters and setters with RequestChangesGuard. It will be replaced in the next commit with: - Setters: The same but async. - Getters: signal on change.
Configuration menu - View commit details
-
Copy full SHA for 5cfc4a3 - Browse repository at this point
Copy the full SHA 5cfc4a3View commit details -
Configuration menu - View commit details
-
Copy full SHA for d65c1d0 - Browse repository at this point
Copy the full SHA d65c1d0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 00acb14 - Browse repository at this point
Copy the full SHA 00acb14View commit details -
Configuration menu - View commit details
-
Copy full SHA for aac5600 - Browse repository at this point
Copy the full SHA aac5600View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4082d78 - Browse repository at this point
Copy the full SHA 4082d78View commit details -
Configuration menu - View commit details
-
Copy full SHA for 67186e2 - Browse repository at this point
Copy the full SHA 67186e2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6f36515 - Browse repository at this point
Copy the full SHA 6f36515View commit details -
Track::createTCO: avoid creating tcos while rendering.
This commit renames createTCO to unsafeCreateTCO and add a mixer guard on the new createTCO.
Configuration menu - View commit details
-
Copy full SHA for 0f8c6d6 - Browse repository at this point
Copy the full SHA 0f8c6d6View commit details -
SampleBuffer: Make setX functions async, remove get functions
and add UpdatingVariable for SampleBuffer's info.
Configuration menu - View commit details
-
Copy full SHA for 855b070 - Browse repository at this point
Copy the full SHA 855b070View commit details -
SampleBuffer & SampleTCO visualization: visualize async only
after an update from the SampleBuffer.
Configuration menu - View commit details
-
Copy full SHA for 8dc1475 - Browse repository at this point
Copy the full SHA 8dc1475View commit details -
Track: put mixer syncs in tco remove/add in order to avoid
data races between the gui and the mixer.
Configuration menu - View commit details
-
Copy full SHA for 1c42efa - Browse repository at this point
Copy the full SHA 1c42efaView commit details -
SampleRecordHandle: move calls to SampleBuffer's methods
out of the rendering threads in order to avoid deadlocks while trying to sync with the mixer.
Configuration menu - View commit details
-
Copy full SHA for 98d1062 - Browse repository at this point
Copy the full SHA 98d1062View commit details -
SampleRecordHandle: Add guard before setting startRecordTimeOffset
in external thread.
Configuration menu - View commit details
-
Copy full SHA for cd6ad7a - Browse repository at this point
Copy the full SHA cd6ad7aView commit details -
Threading: Add runAccordingToLaunchType helper that will run
a callable async / sync in the same thread according to a variable.
Configuration menu - View commit details
-
Copy full SHA for 7d8fdff - Browse repository at this point
Copy the full SHA 7d8fdffView commit details -
Configuration menu - View commit details
-
Copy full SHA for cde4baa - Browse repository at this point
Copy the full SHA cde4baaView commit details -
Configuration menu - View commit details
-
Copy full SHA for ab180b0 - Browse repository at this point
Copy the full SHA ab180b0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 91c6e96 - Browse repository at this point
Copy the full SHA 91c6e96View commit details -
Configuration menu - View commit details
-
Copy full SHA for a7236e4 - Browse repository at this point
Copy the full SHA a7236e4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 444e638 - Browse repository at this point
Copy the full SHA 444e638View commit details