Recording after rebase to master #4994

Reflexe · 2019-05-26T07:44:56Z

This is a refactored and rebased-to-master version of #4531 .

Bugs

TripleOscillator preset previews show errors and don't stop due to nonexistent samples/empty.wav
w2_invsinehalf.flac has a furry tail in BitInvader due to resampling(maybe an issue with Graph?)
Visualization gets weird when resizing tracks while recording

Enhancements

tick 0)

audioPort as nullptr by default.

frames by the masterGain.

support.

SampleTCOs.

"played" (recorded).

SampleBuffer. That solves problem with recording that caused samples to be moved and messed up. Thanks @-BaraMGB for helping.

Previously, begining record in any position would result the data being in the end of the TCO. @see LMMS#3947 (comment) Thanks to @-BaraMGB :)

`updateMenu`, use a virtual function overriden by every Track implemetation.

input channel configurations. And support recording of one channel and converting it to two. The user would be able to set their input config per track, or globally. For each recorded sampletrack, the recorded will get the channel config and will duplicate the samples from one channel to the other in a case of mono input.

options unchecked will be considered as global default. Suggested by @-tresf, Thanks!

actual data starts after that.

instead of hacking sampleBuffer ()->startFrame (). That solves a bug with `startFrame ()` being negetive in recording some cases.

rate. The deadblock was caused by the mixer stopping which make the recording thread to wait until it get started again and in the other side, the exporting thread which wants to acquire a mutex that had been locked by the recording thread. Many thanks to PhysSong :)

support is not available. Thanks to @-Sawuare.

played correctly after saving and loading a project due to sample rate not getting saved in the project file.

right place when it not played from the begining. That has created a difference between the ticks and the metronome and the sample track. The cause of the problem was that the calculation of the frame to play was wrong: we had calculated `framesPerTick` according to the current engine's sample rate instead of the SampleBuffer's sample rate.

automaticlly create "record sample tco" if there is no recording tco. This commit adds per-track record setting. If a sample track is set as record, lmms will check if there is a tco that set to record: * If there is, it will record into it. * If there is not, it will create a special tco that get created on recording, and as long as the recording.

and SampleTrack::m_recordingChannel.

avoid a warning. Thanks to @-PhysSong.

Many thanks to @-PhysSong.

PhysSong · 2019-09-16T04:22:17Z

@Reflexe Sorry for repetitively bumping this, but do you have any further plans on this PR? It's one of the features with many demands.

Reflexe · 2019-09-19T12:43:07Z

@Reflexe Sorry for repetitively bumping this, but do you have any further plans on this PR? It's one of the features with many demands.

Sorry about the delay. I'm actively working on this locally and will keep your all updated.

PhysSong · 2019-10-26T01:49:31Z

The biggest problem of this PR is that it's very hard to review. I think this PR mainly consists of:

changes in SampleBuffer and follow-ups in other classes
core changes that enable recording
UI changes for capturing audio
backend-specific capturing implementations
build system changes

@Reflexe As you may know, the changes in SampleBuffer dominates this PR, making the core functionality hard to review. Since the core functionality heavily depends on those changes, I think you should open a new PR for SampleBuffer changes to allow other devs to review it.

ChildishGiant · 2020-01-16T17:20:51Z

Any update on this? I feel like this is a key feature for any DAW

PhysSong · 2020-02-04T02:37:31Z

I want to separate this PR into multiple "easier-to-chew" (test and review) PRs. I just can't find the time for it.

@Reflexe Do you want/need some help? If it's the case, I can try.

therealhammer · 2020-04-03T11:29:55Z

Just forked and compiled this branch. Great job! Recording worked pretty good with Jack. Looking forward to see this feature in a release version! :)

gl3nnleblanc · 2020-04-13T01:18:46Z

Sorry if I shouldn't bump this, but any update? My workflow would be heavily improved if this is implemented.

Just forked and compiled this branch. Great job! Recording worked pretty good with Jack. Looking forward to see this feature in a release version! :)

Are there currently any UI elements in place? I built this branch but still see no way to record.

qnebra · 2020-06-20T14:43:15Z

There is a lot more merge conflicts than "non-technical" user can solve.

PhysSong · 2020-11-19T14:03:07Z

As I mentioned a while ago, I'm preparing to revive this PR by splitting to smaller PRs. As far as I understand, this PR consists of:

Backend changes to support audio capture
Some changes in core classes like Mixer, SampleRecordHandle
SampleTrack changes for recording
Massive SampleBuffer refactoring
Threading-related changes
UI changes related to recording
Build system changes(mostly related to JACK on Windows)
Some CI changes, probably not needed anymore
Other minor changes

Now I have to analyze their dependency chain and look into individual commits.

PhysSong · 2020-11-20T06:41:26Z

It seems like only a few changes are actually required if we give up supporting live updates while recording. Live updating requires a lot of changes regarding internal data structure, thread safety, and much more.
While trying to understand changes in this PR, I found some odd code fragments. I built and tried to test this PR, but everything was too unstable and buggy to merge this as-is.
I even had to drop a lot of recent commits to get a version which doesn't break much. This is a result of poorly reviewed and tested code.

PhysSong · 2021-01-01T04:21:59Z

Notes for who are looking for downloads: Due to the merge conflicts, neither I or the bot can't provide downloads as-is. As I mentioned above, this pull request is being reworked by me. It's not ready for review at this moment, and there won't be a new pull request until the project reorganization(#5592) finishes.

If there are enough demands for testing binaries, However, I can consider providing unofficial binaries for the new rebased version(Warning: still WIP!).

Reflexe · 2021-01-10T22:28:55Z

I remember trying a few odd things on the latest commits. Removing them should give a relatively working recording functionality.

Do you have specific instabilities / errors?

brigazvi · 2021-04-14T22:07:20Z

Is there any reason to not merge it to master?

IanCaio · 2021-04-14T22:25:35Z

Is there any reason to not merge it to master?

That's one of them:

This branch has conflicts that must be resolved

Conflicting files
.travis/linux..install.sh
CMakeLists.txt
include/AudioSampleRecorder.h
include/AutomationTrack.h
include/BBTrack.h
include/Engine.h
include/InstrumentTrack.h
include/SampleBuffer.h
include/SampleRecordHandle.h
include/SampleTrack.h
include/SongEditor.h
include/Track.h
include/lmms_basics.h
plugins/audio_file_processor/audio_file_processor.cpp
src/CMakeLists.txt
src/core/Effect.cpp
src/core/Mixer.cpp
src/core/SampleBuffer.cpp
src/core/SamplePlayHandle.cpp
src/core/SampleRecordHandle.cpp
src/core/Song.cpp
src/core/Track.cpp
src/core/audio/AudioDevice.cpp
src/core/audio/AudioJack.cpp
src/core/audio/AudioSdl.cpp
...

netpipe · 2021-05-10T05:24:12Z

it will need to be updated to merge it now ?

PhysSong · 2021-05-10T06:17:07Z

This one is being continued in #5990 and probably more future PRs.

Reflexe · 2021-05-17T13:42:34Z

Moved here: #5990

Reflexe added 30 commits May 26, 2019 10:18

SampleTrack: Uncomment disabled recording-related code.

8fd89ee

SampleTrack: Fix TCO not being played on the first tick (if it starts on

e86fd69

tick 0)

AudioJack: Basic implementation of capture (without AUDIO_PORT_SUPPORT)

34eb63c

Mixer & PlayHandle: Support PlayHandle without audioPort and set

1720fcd

audioPort as nullptr by default.

Mixer -> pushInputFrames: Add an option to automaticly normalize input

7074ac8

frames by the masterGain.

AudioPulseAudio: Switch playback sample type to float and add capture

86eb13f

support.

Track -> SampleTrack: Do not save start time offset for empty

45a484a

SampleTCOs.

AudioJack: Allocate and deallocate m_tempInBufs.

c4b69a3

SampleTrack: Make sure an empty TCO with isRecord would still be

0a9debc

"played" (recorded).

SampleTrack: Reset the start time offset when importing a new

f72c5d9

SampleBuffer. That solves problem with recording that caused samples to be moved and messed up. Thanks @-BaraMGB for helping.

SampleRecordHandle: Apply start offset to reocrded TCO.

5241b4b

Previously, begining record in any position would result the data being in the end of the TCO. @see LMMS#3947 (comment) Thanks to @-BaraMGB :)

Track, TrackView: Instead of trying every possible dynamic_cast in

55029bd

`updateMenu`, use a virtual function overriden by every Track implemetation.

Editor -> Style: Reorder editor buttons.

e290203

SampleTrack -> RecordingChannel: Remove the default option, instead, all

48fea61

options unchecked will be considered as global default. Suggested by @-tresf, Thanks!

SampleTrack: Change recordingChannel menu label.

6feeb4a

SampleTrack: In a case of recording, play a sample TCO even if its

1bb14b5

actual data starts after that.

SampleRecordHandle: Obtain the offset to the record with a parameter

cbd669c

instead of hacking sampleBuffer ()->startFrame (). That solves a bug with `startFrame ()` being negetive in recording some cases.

SongEditor: Hide the global channel selection toolbox when capture

31a69dd

support is not available. Thanks to @-Sawuare.

SongEditor: Hide the record button.

52eef80

Bugfix - SampleTrack -> Load & Save: Fix recorded sample track not being

1e9845f

played correctly after saving and loading a project due to sample rate not getting saved in the project file.

SampleTrack: On project save, save the values of SampleTrack::m_record

16dc30b

and SampleTrack::m_recordingChannel.

SampleTrack -> Minor: Reorder the constructor initialization order to

0b2d8a7

avoid a warning. Thanks to @-PhysSong.

Travis: Use SDL2 on Windows.

75f84d6

Travis -> InstallRaw: Fix Shellcheck warnings.

70f2046

Travis -> Linux: Use SDL2 by default.

96ccbfe

CMake -> Install: Install SDL2.dll instead of SDL.dll.

5f68c8b

Many thanks to @-PhysSong.

PhysSong mentioned this pull request Oct 6, 2019

Oversampling changes pitch for AFP #5218

Closed

LostRobotMusic mentioned this pull request Dec 15, 2019

audio recording #5346

Closed

PhysSong mentioned this pull request May 26, 2020

Knife Tool for Sample Clips #4998

Merged

Spekular mentioned this pull request May 27, 2020

Recording module #5520

Closed

PhysSong mentioned this pull request Jun 12, 2020

Lv2 core implementation #4899

Closed

PhysSong mentioned this pull request Jul 9, 2020

Sample track cuts off first buffer of the sample #5553

Closed

ryuukumar mentioned this pull request Jul 21, 2020

Reorganising LMMS, renaming editors and classes and everything in between (cont. #120) #5592

Closed

56 tasks

PhysSong added rework required Pull requests which must be reworked to make it able to merge or review and removed needs code review A functional code review is currently required for this PR needs style review A style review is currently required for this PR labels Jan 4, 2021

netpipe mentioned this pull request May 10, 2021

multi user recording options #6010

Open

Reflexe closed this May 17, 2021

PhysSong mentioned this pull request Oct 8, 2023

Sample Track Recording Stage One #5990

Draft

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Recording after rebase to master #4994

Recording after rebase to master #4994

Reflexe commented May 26, 2019 •

edited

Loading

PhysSong commented Sep 16, 2019

Reflexe commented Sep 19, 2019

PhysSong commented Oct 26, 2019

ChildishGiant commented Jan 16, 2020

PhysSong commented Feb 4, 2020

therealhammer commented Apr 3, 2020

gl3nnleblanc commented Apr 13, 2020

qnebra commented Jun 20, 2020

PhysSong commented Nov 19, 2020

PhysSong commented Nov 20, 2020

PhysSong commented Jan 1, 2021

Reflexe commented Jan 10, 2021

brigazvi commented Apr 14, 2021

IanCaio commented Apr 14, 2021

netpipe commented May 10, 2021

PhysSong commented May 10, 2021

Reflexe commented May 17, 2021

Recording after rebase to master #4994

Recording after rebase to master #4994

Conversation

Reflexe commented May 26, 2019 • edited Loading

Bugs

Enhancements

PhysSong commented Sep 16, 2019

Reflexe commented Sep 19, 2019

PhysSong commented Oct 26, 2019

ChildishGiant commented Jan 16, 2020

PhysSong commented Feb 4, 2020

therealhammer commented Apr 3, 2020

gl3nnleblanc commented Apr 13, 2020

qnebra commented Jun 20, 2020

PhysSong commented Nov 19, 2020

PhysSong commented Nov 20, 2020

PhysSong commented Jan 1, 2021

Reflexe commented Jan 10, 2021

brigazvi commented Apr 14, 2021

IanCaio commented Apr 14, 2021

netpipe commented May 10, 2021

PhysSong commented May 10, 2021

Reflexe commented May 17, 2021

Reflexe commented May 26, 2019 •

edited

Loading