-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Application Style #34
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original source files used 4 spaces. The project's maintainer requested tabs.
This allows multiple projects, most importantly a Test Project
... because VS misbehaves if multiple projects are in the same root, but their files are in subdirectories
Using Xunit for C#
This will allow contributors to know when they are violating our style guidelines. It also allows contributors to conform without having to change their own editor's configuration as it serves as a project level config. see [http://editorconfig.org/]
Based on [PR 33](Kyle-Undefined#33)
Just to be clear, there are currently no tests, just the basest framework. |
From here on out, all PRs will be specific and squashed, creating a compact linear history. It would be ideal to know our versioning strategy, but I can understand if that must wait until full modularization. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes a number of organizational changes, but not functional. It also establishes our own conformance to the conventions that we have currently set. The need for this PR is to begin the framework to allow for mocking and testing into the CI/CD workflow. The ultimate goal, of course, is automation. In the meantime, we can run tests manually on the local machine.
This also includes tools to allow contributors to conform to our coding standards and practices.