-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set Styles and Conventions #37
Comments
Per PR #33, parameters/arguments should be camelCase. I prefer constants and enum properties that have constant type values to be in CAPITAL_CASE. Do you agree, @Kyle-Undefined? |
@FuzzicalLogic I don't like capital case as it grabs too much attention. I prefer Pascal Case for enums. Don't really have a preference for constants. If you want to have those to be capital case, that's fine. |
I've also started adding events to the code. The standard for event handlers in .Net used to be So, I recommend in cases where the event handler is a class method, we stick to the |
This is going to be a long-term issue until we feel most of the baselines are covered in terms of Tokens and Patterns. This issue is made specifically to provide a forum for questions and discussion of the conventions and style used within PoE-Bot.
As of PR #34, there will be the beginnings of STYLE_GUIDE.md for contributors to our project to follow. To enable conformance, .editorconfig will help with editor behaviors specific to PoE-Bot and issue notices and warnings for failure to conform.
As such, each STYLE_GUIDE addition that requires any form or character or format conformance, will have a relevant change to .editorconfig.
The text was updated successfully, but these errors were encountered: