Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AdminBundle][FosuUserBundle] Deprecate FosUserBundle #2737

Merged
merged 139 commits into from
May 23, 2021
Merged

[AdminBundle][FosuUserBundle] Deprecate FosUserBundle #2737

merged 139 commits into from
May 23, 2021

Conversation

Numkil
Copy link
Contributor

@Numkil Numkil commented Sep 11, 2020

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? yes
Fixed tickets

todo:

write deprecation messages everywhere
write guide

Copy link

@ProfessorKuma ProfessorKuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @, your PR needs some changes

  • Your answer if this PR is a bugfix seems to be incorrect.
  • Your answer if this PR is a new feature seems to be incorrect.
  • Your answer if this PR is BC breaking seems to be incorrect.
  • Your answer if this PR is has deprecations seems to be incorrect.
  • your PR title should look like [SomeBundle] Fixed some code

@Numkil Numkil changed the title WIP: Deprecate fos user merel [AdminBundle][FosuUserBundle] Deprecate FosUserBudnle Sep 25, 2020
@Numkil Numkil changed the title [AdminBundle][FosuUserBundle] Deprecate FosUserBudnle [AdminBundle][FosuUserBundle] Deprecate FosUserBundle Sep 25, 2020
@ProfessorKuma ProfessorKuma added this to the 5.7.0 milestone Sep 25, 2020
Copy link

@ProfessorKuma ProfessorKuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @, your PR needs some changes

  • This PR seems to need a milestone of a minor release.

Copy link

@ProfessorKuma ProfessorKuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @, your PR passed all our requirements.

Thank you for contributing!

@acrobat acrobat mentioned this pull request Mar 12, 2021
@acrobat acrobat modified the milestones: 5.8.0, 5.9.0 Mar 17, 2021
…r-merel

* upstream/master:
  Update branch alias
  Generate assets for 5.8.0 release
  Update changelog for 5.8.0 release
  Generate assets for 5.7.2 release
  Update changelog for 5.7.2 release
  Generate assets for 5.6.5 release
  Update changelog for 5.6.5 release
  [All bundles] added postgres support (#2849)
  [NodeBundle] fixed unpublish later
  [AllBundles] Setup deprecations baseline
  [GeneratorBundle] Fix php syntax errors in generator skeleton files
  [MediaBundle] Bump imagine dependencies
  [AllBundles] Enhancement: Remove .idea/ and .DS_Store from .gitignore files
…r-merel

* upstream/master:
  Add length validation to form fields
  Use parameter instead of hardcoded media path
  [RedirectBundle] Move redirect entity class override to config
  [AdminBundle] Add config option to disabled exception logging module
  [UserManagementBundle] Move user adminlist configurator class override to config
  [GeneratorBundle] Deprecate generate bundle and entity commands
  [AllBundles] Mark event classes final
  [Dashboardbundle] Rework dashboard command calls
  [NodeSearchBundle] Deprecate direct instantiation of the abstractSearchPage
  [AdminlistBundle] Deprecate setter methods in EntityVersionLockService
  [GeneratorBundle] Switch to new doctrine inflector api
  Update index.md
  [MultiDomainBundle] Fix keying of host configurations (#2848)
  [RedirectBundle] Fix broken wildcard redirects
  [AllBundles] Bump minimum stof/doctrine-extensions-bundle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants