[MultiDomainBundle] Fix keying of host configurations #2848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ProfessorKuma
suggested changes
Feb 9, 2021
ProfessorKuma
approved these changes
Feb 9, 2021
|
Thanks @waaghals! |
acrobat
added a commit
that referenced
this pull request
Apr 4, 2021
* 5.6: [MultiDomainBundle] Fix keying of host configurations (#2848) [RedirectBundle] Fix broken wildcard redirects
acrobat
added a commit
that referenced
this pull request
Apr 4, 2021
* 5.7: [MultiDomainBundle] Fix keying of host configurations (#2848) [RedirectBundle] Fix broken wildcard redirects
acrobat
added a commit
that referenced
this pull request
Apr 4, 2021
* 5.8: [MultiDomainBundle] Fix keying of host configurations (#2848) [RedirectBundle] Fix broken wildcard redirects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the configuration for the hosts in the multi domain bundle.
When modifying the configuration from another bundle (using PrependExtensionInterface) the configuration get re-indexed by the Symfony configuration component. This cause the configuration to be added twice.
Once using the origin key (the modified configuration) and once using numeric ids re-indexed by Symfony.
I figured this was attempted previously as the code is commented out. Enabling this as-is will remove the 'host' configuration field. (as it is should only be used as the key, not a value).
By using a different name for the attribute, the original configuration is left as is. And Symfony now uses the correct value as the key.