Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sad state of the world #244

Closed
wants to merge 1 commit into from
Closed

Sad state of the world #244

wants to merge 1 commit into from

Conversation

alexsnaps
Copy link
Member

No description provided.

@alexsnaps alexsnaps marked this pull request as ready for review December 14, 2023 15:58
@alexsnaps
Copy link
Member Author

I wanna cry... all of this is broken beyond belief:

  • For some reason, I can't access the project thru the GraphQL API: Resource not accessible by integration
  • Couldn't find any way to enable the reads for the action
  • So fell back to just skipping if the secret isn't there... sad
  • Also know that for some reason, on some conditions, GH just decides to skip this action and I had to create I don't know how many PRs to test this

eguzki
eguzki reviewed Dec 18, 2023
View reviewed changes
.github/workflows/issues-workflow.yaml
- uses: actions/[email protected]
if: steps.secret.outputs.inputsChecked == 'true'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you try the following??

if: secrets.ADD_ISSUES_TOKEN != ''

Maybe it works (I have not tried myself)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to check this Kuadrant/kuadrant-operator#385

Implementing the same for the kuadrant opeator

@alexsnaps alexsnaps closed this Jan 15, 2024
@alexsnaps alexsnaps deleted the gh_crap branch January 15, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eguzki eguzki eguzki left review comments

@adam-cattermole adam-cattermole adam-cattermole approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexsnaps @eguzki @adam-cattermole