-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh actions: issues workflow: disable job on forked PR's OR it's an issue #385
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #385 +/- ##
==========================================
- Coverage 65.29% 64.63% -0.66%
==========================================
Files 35 35
Lines 3795 3795
==========================================
- Hits 2478 2453 -25
- Misses 1125 1145 +20
- Partials 192 197 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
|
f452f60
to
2f0da31
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me.
integration tests failing 😢 |
Another approach would be to have two workflows, one for issues opened and the other for PR's not coming from forked repos |
When the feature branch is in the
Kuadrant/kuadrant-operator
repo the github action context looks like this:when the feature brnach is in another repo (forked one) and opens PR in this repo, the context looks like this:
When we want to disable job on PR's coming from forked repos to prevent it from failing (because there is no access to secrets), that is the cleanest way so far.
Issues workflow will also be run when an issue is being opened.
Tested: