Build images with replaces operator image #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #103 +/- ##
=======================================
Coverage 52.24% 52.24%
=======================================
Files 12 12
Lines 867 867
=======================================
Hits 453 453
Misses 374 374
Partials 40 40
Flags with carried forward coverage won't be shown. Click here to find out more.
|
didierofrivia
force-pushed
the
build-images-with-replaces-version
branch
from
befbcae
to
1e65e61
Compare
eguzki
requested changes
Sep 28, 2023
There was a problem hiding this comment.
Update the development guide about Build Custom Catalog. When building a catalog I think that the only required input param should be BUNDLE_IMG. The other parameters either have default values or can be inferred by the script.
didierofrivia
force-pushed
the
build-images-with-replaces-version
branch
from
1e65e61
to
d14a8f8
Compare
didierofrivia
force-pushed
the
build-images-with-replaces-version
branch
from
4ca9369
to
d6db26a
Compare
eguzki
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the discrepancy between the bundle replaces value provided to OperatorHub (by hand) and our bundle and catalog images (missing until now). It aims to fix the failing tests in both https://github.com/k8s-operatorhub/community-operators/actions/runs/6323398403/job/17171016267?pr=3298 and https://github.com/redhat-openshift-ecosystem/community-operators-prod/actions/runs/6323474102/job/17171305652?pr=3350 .
Notes:
A re-release needs to be done... either using this mod or by hand including the replaces in the catalog and bundle.