Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RateLimitPolicy guide to follow after gateway walkthrough #612

Merged
merged 5 commits into from
Oct 16, 2023

Conversation

jasonmadigan
Copy link
Member

@jasonmadigan jasonmadigan commented Sep 28, 2023

Kuadrant/docs.kuadrant.io#14

Some copied and modified guides as jumping-off points from the multicluster gateway walkthrough, based on:

Main thing changed here is:

  • Updated setup, with the view that you've already run the quickstart+gateway walkthrough guide, so you've got Gateways, TLSPolicy+DNSpolicy already setup
  • Rest of the guide is largely as-is, apart from some changes owing to the fact that you'll have working DNS

Steps to test

Related

Follow-on

Create a similar AuthPolicy guide (parked for now in 14-ap-guide)

@jasonmadigan jasonmadigan changed the title initial RateLimitPolicy + AuthPolicy guides to follow after gateway walkthrough Sep 28, 2023
@jasonmadigan
Copy link
Member Author

jasonmadigan commented Sep 28, 2023

@guicassolato hopefully gives you an idea as to what I'm at. Can incorporate your new guide once you think it's in a good place

@jasonmadigan
Copy link
Member Author

Leaving this here for someone else - here's how to use a pre-release operator catalog to test preview service protection addon stuff:

https://gist.github.com/jasonmadigan/bde64d4967fdbb740fd8eb876f2579dc

@jasonmadigan jasonmadigan force-pushed the 14-rlp-ap-guides branch 5 times, most recently from 76e4e64 to 1e92be0 Compare October 3, 2023 11:41
@jasonmadigan jasonmadigan marked this pull request as ready for review October 3, 2023 11:43
@jasonmadigan
Copy link
Member Author

TODO: New Nav in a docs.kuadrant.io PR.

@jasonmadigan
Copy link
Member Author

Would like a final @guicassolato step through too for sanity, but appreciate that may be hard to do this week

Copy link
Contributor

@laurafitzgerald laurafitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I stepped through the guide and everything worked as expected. Some small comments inline.

@jasonmadigan
Copy link
Member Author

thanks @laurafitzgerald - have added

@jasonmadigan
Copy link
Member Author

After chatting with @maleck13 a bit, I think we're going to land the AuthPolicy guide a little later when v1beta2 is available, so I'll split this PR in two and land the RLPV2 bits first.

@jasonmadigan jasonmadigan changed the title RateLimitPolicy + AuthPolicy guides to follow after gateway walkthrough RateLimitPolicy guides to follow after gateway walkthrough Oct 9, 2023
@jasonmadigan
Copy link
Member Author

Have now split this up so this only incorporates a RLV2 guide - a new authpolicy guide can come when we ship the 0.5.0 Kuadrant operator.

I've parked the AuthPolicy guide as it is in 14-ap-guide on my fork.

@jasonmadigan jasonmadigan changed the title RateLimitPolicy guides to follow after gateway walkthrough RateLimitPolicy guide to follow after gateway walkthrough Oct 9, 2023
done
```

> **Note:** It may take a couple of minutes for the RateLimitPolicy to be applied depending on your cluster.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be worth a note here that this limit is per cluster hosting the echo service

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jasonmadigan, maleck13

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jasonmadigan,maleck13]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@maleck13
Copy link
Contributor

/lgtm
This looks to have been tried and reviewed. If there are minor tweaks needed we can do them as follow ups

@openshift-ci openshift-ci bot added the lgtm label Oct 16, 2023
@openshift-ci openshift-ci bot merged commit 6965b6a into Kuadrant:main Oct 16, 2023
1 check passed
@jasonmadigan jasonmadigan deleted the 14-rlp-ap-guides branch October 16, 2023 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved documentation Improvements or additions to documentation lgtm
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

New RateLimitPolicy guide to follow after gateway walkthrough
4 participants