-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RateLimitPolicy guide to follow after gateway walkthrough #612
Conversation
957f5b8
to
31ee6c7
Compare
@guicassolato hopefully gives you an idea as to what I'm at. Can incorporate your new guide once you think it's in a good place |
d208202
to
bb169e1
Compare
bb169e1
to
d6618d1
Compare
Leaving this here for someone else - here's how to use a pre-release operator catalog to test preview service protection addon stuff: https://gist.github.com/jasonmadigan/bde64d4967fdbb740fd8eb876f2579dc |
76e4e64
to
1e92be0
Compare
TODO: New Nav in a docs.kuadrant.io PR. |
Would like a final @guicassolato step through too for sanity, but appreciate that may be hard to do this week |
…onnected to the MG walkthrough mend
1e92be0
to
bdcf227
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I stepped through the guide and everything worked as expected. Some small comments inline.
d78ab08
to
90c117a
Compare
thanks @laurafitzgerald - have added |
After chatting with @maleck13 a bit, I think we're going to land the AuthPolicy guide a little later when v1beta2 is available, so I'll split this PR in two and land the RLPV2 bits first. |
Co-authored-by: Laura Fitzgerald <[email protected]>
90c117a
to
d1380f2
Compare
Have now split this up so this only incorporates a RLV2 guide - a new authpolicy guide can come when we ship the 0.5.0 Kuadrant operator. I've parked the AuthPolicy guide as it is in 14-ap-guide on my fork. |
done | ||
``` | ||
|
||
> **Note:** It may take a couple of minutes for the RateLimitPolicy to be applied depending on your cluster. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be worth a note here that this limit is per cluster hosting the echo service
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jasonmadigan, maleck13 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Kuadrant/docs.kuadrant.io#14
Some copied and modified guides as jumping-off points from the multicluster gateway walkthrough, based on:
Main thing changed here is:
Steps to test
Related
Follow-on
Create a similar AuthPolicy guide (parked for now in
14-ap-guide
)