Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wasm shim image env var name does not match deployment var name #136

Merged
merged 1 commit into from
Jan 17, 2023

Conversation

eguzki
Copy link
Contributor

@eguzki eguzki commented Jan 13, 2023

What

Fixes #128

The deployment objects sets RELATED_IMAGE_WASMSHIM

 env:                                                   
   - name: RELATED_IMAGE_WASMSHIM                         
     value: "oci://quay.io/kuadrant/wasm-shim:v0.1.0"     
 image: controller:latest                               

But the code was reading WASM_FILTER_IMAGE

Verification Steps

run dev env

make local-env-setup

Run Operator's controllers with the env var name expected RELATED_IMAGE_WASMSHIM

RELATED_IMAGE_WASMSHIM=oci://quay.io/kuadrant/wasm-shim:v0.1.0 make run

Create kuadrant CR

k apply -f - <<EOF
---
apiVersion: kuadrant.kuadrant.io/v1beta1
kind: Kuadrant
metadata:
  name: kuadrant-sample
spec: {}
EOF

Create some HTTPRoute and RLP

k apply -f examples/toystore/httproute.yaml
k apply -f examples/toystore/ratelimitpolicy_httproute.yaml

Check wasmplugin for the wasm shim URL

k get WasmPlugin -n istio-system kuadrant-istio-ingressgateway -o jsonpath="{.spec.url}" | yq e -P
oci://quay.io/kuadrant/wasm-shim:v0.1.0

It should be oci://quay.io/kuadrant/wasm-shim:v0.1.0 instead of the latest oci://quay.io/kuadrant/wasm-shim:latest

@eguzki eguzki requested a review from a team as a code owner January 13, 2023 08:58
@eguzki eguzki mentioned this pull request Jan 13, 2023
@eguzki eguzki merged commit 7ac693e into main Jan 17, 2023
@eguzki eguzki deleted the fix-wash-shim-var-name branch January 17, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WASMShim version is not locked
3 participants