Fix conditions in examples #123
Merged
+11
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guicassolato
approved these changes
Dec 21, 2022
eguzki
requested changes
Dec 21, 2022
alexsnaps
force-pushed
the
conditions
branch
from
b5aa7a6
to
b33952e
Compare
alexsnaps
force-pushed
the
conditions
branch
from
b33952e
to
c516312
Compare
|
Good catch @eguzki ! |
eguzki
approved these changes
Dec 21, 2022
|
by the way, do we have this limitation documented? I cannot find in https://github.com/Kuadrant/limitador/blob/main/doc/migrations/conditions.md |
Yeah, no... it's not in there. Or say not directly. Hard to document what really has changed, might be better to just document what makes a valid identifier? e.g. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tho they work, they rely on the lenient mode in limitador