Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] Moving GetObjectType in tree.h #11739

Merged
merged 1 commit into from
Nov 6, 2023
Merged

[Core] Moving GetObjectType in tree.h #11739

merged 1 commit into from
Nov 6, 2023

Conversation

loumalouomega
Copy link
Member

📝 Description

This commit refactors the GetObjectType template in the kratos/spatial_containers/tree.h file. The changes include moving the original GetObjectType template inside the class.

🆕 Changelog

@loumalouomega loumalouomega added Kratos Core FastPR This Pr is simple and / or has been already tested and the revision should be fast Refactor When code is moved or rewrote keeping the same behavior labels Oct 31, 2023
@loumalouomega loumalouomega requested a review from a team as a code owner October 31, 2023 10:48
@loumalouomega loumalouomega mentioned this pull request Oct 31, 2023
Merged
This was referenced Oct 31, 2023
Merged
Open
@loumalouomega
Copy link
Member Author

@roigcarlo @pooyan-dadvand

roigcarlo
roigcarlo approved these changes Nov 6, 2023
View reviewed changes
Copy link
Member

@roigcarlo roigcarlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't I approve this one already?

@loumalouomega loumalouomega merged commit 44e5005 into master Nov 6, 2023
10 of 11 checks passed
@loumalouomega loumalouomega deleted the core/moving-definition branch November 6, 2023 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roigcarlo roigcarlo roigcarlo approved these changes

@pooyan-dadvand pooyan-dadvand Awaiting requested review from pooyan-dadvand

Assignees
No one assigned
Labels
FastPR This Pr is simple and / or has been already tested and the revision should be fast Kratos Core Refactor When code is moved or rewrote keeping the same behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@loumalouomega @roigcarlo