Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Adding GetObjectType and define ObjectType in Tree #11737

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

loumalouomega
Copy link
Member

📝 Description

Adding GetObjectType and define ObjectType in Tree. The ObjectType is taken from PointType when this is defined, otherwise void is defined. An auxiliary static method is defined in order to determine when ObjectType is defined.

🆕 Changelog

@loumalouomega loumalouomega added Kratos Core FastPR This Pr is simple and / or has been already tested and the revision should be fast Transition labels Oct 30, 2023
@loumalouomega loumalouomega requested a review from a team as a code owner October 30, 2023 15:16
Copy link
Member

@roigcarlo roigcarlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey didn't know that trick. That's actually super useful 👍

@loumalouomega
Copy link
Member Author

Hey didn't know that trick. That's actually super useful 👍

It is the result of hree hours of Google + Stackoverflow and GPT4 (the idea was from GPT4 but the promt was the result of hours of iterations with Google + Stackoverflow)

@loumalouomega loumalouomega merged commit c3cc87a into master Oct 31, 2023
10 of 11 checks passed
@loumalouomega loumalouomega deleted the core/define-ObjectType-tree branch October 31, 2023 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FastPR This Pr is simple and / or has been already tested and the revision should be fast Kratos Core Transition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants