Skip to content

Rename KClass<*>.isInterface helper in the JS part #3027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 25, 2025
Merged

Rename KClass<*>.isInterface helper in the JS part #3027

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
60c6595
Rename KClass<*>.isInterface helper in the JS part
broadwaylamb Jun 25, 2025
293f725
Update core/jsMain/src/kotlinx/serialization/internal/Platform.kt
sandwwraith Jun 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions core/jsMain/src/kotlinx/serialization/internal/Platform.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ internal actual fun <T : Any> KClass<T>.compiledSerializerImpl(): KSerializer<T>
else this.js.asDynamic().Companion?.serializer()
) as? KSerializer<T>

internal actual fun <T: Any> KClass<T>.isInterface(): Boolean = isInterface
internal actual fun <T: Any> KClass<T>.isInterface(): Boolean = isInterfaceHack

internal actual fun <T> createCache(factory: (KClass<*>) -> KSerializer<T>?): SerializerCache<T> {
return object: SerializerCache<T> {
Expand Down Expand Up @@ -73,8 +73,10 @@ internal actual fun isReferenceArray(rootClass: KClass<Any>): Boolean = rootClas
* WARNING: may be broken in arbitrary time in the future without notice
*
* Should be eventually replaced with compiler intrinsics
*
* TODO: Remove this when KT-78581 lands into a 2.2.20 release
*/
private val KClass<*>.isInterface: Boolean
private val KClass<*>.isInterfaceHack: Boolean
get(): Boolean {
// .js throws an exception for Nothing
if (this === Nothing::class) return false
Expand Down