Rename KClass<*>.isInterface helper in the JS part #3027
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandwwraith
reviewed
Jun 25, 2025
| * | ||
| * Should be eventually replaced with compiler intrinsics | ||
| * | ||
| * TODO: Remove this when KT-78581 lands into a release |
There was a problem hiding this comment.
Do you have a release version in mind?
There was a problem hiding this comment.
2.2.20 hopefully
|
PRs should be based against |
We are going to introduce a new KClass member in the standard library with the same name marked with an opt-in annotation, so in the usages of this extension property would stop compiling because the member is always favored and there is no opt-in. See KT-78581
broadwaylamb
force-pushed
the
broadwaylamb/js-isinterface
branch
from
39e278b to
60c6595
Compare
sandwwraith
approved these changes
Jun 25, 2025
broadwaylamb
added a commit
that referenced
this pull request
Jun 25, 2025
We are going to introduce a new KClass member in the standard library with the same name marked with an opt-in annotation, so in the usages of this extension property would stop compiling because the member is always favored and there is no opt-in. See KT-78581
broadwaylamb
added a commit
that referenced
this pull request
Jul 2, 2025
We are going to introduce a new KClass member in the standard library with the same name marked with an opt-in annotation, so in the usages of this extension property would stop compiling because the member is always favored and there is no opt-in. See KT-78581 (cherry picked from commit fee0ab1)
woainikk
pushed a commit
that referenced
this pull request
Jul 2, 2025
We are going to introduce a new KClass member in the standard library with the same name marked with an opt-in annotation, so in the usages of this extension property would stop compiling because the member is always favored and there is no opt-in. See KT-78581 (cherry picked from commit fee0ab1)
JesusMcCloud
pushed a commit
to JesusMcCloud/kotlinx.serialization
that referenced
this pull request
Aug 5, 2025
We are going to introduce a new KClass member in the standard library with the same name marked with an opt-in annotation, so in the usages of this extension property would stop compiling because the member is always favored and there is no opt-in. See KT-78581
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are going to introduce a new KClass member in the standard library with the same name marked with an opt-in annotation, so in the usages of this extension property would stop compiling because the member is always favored and there is no opt-in.
See KT-78581